Closed
Bug 1053743
Opened 11 years ago
Closed 11 years ago
Localize content in app/index.html
Categories
(Webmaker Graveyard :: Profile, defect)
Webmaker Graveyard
Profile
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Tanay, Assigned: Tanay, Mentored)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446
Steps to reproduce:
We should make the localization even in the content below highlighted lines:
https://github.com/mozilla/webmaker-profile-2/blob/master/app/index.html#L106
(That is the tabs)
I will take care of this bug.
| Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(aki)
| Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8472939 -
Flags: review?(aki)
Updated•11 years ago
|
Assignee: nobody → tanay1337
Mentor: aki
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(aki)
Comment 2•11 years ago
|
||
Comment on attachment 8472939 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/78
One little change (comment on the PR) and it's good to go!
Attachment #8472939 -
Flags: review?(aki) → review-
| Assignee | ||
Updated•11 years ago
|
Attachment #8472939 -
Flags: review- → review?(aki)
Updated•11 years ago
|
Attachment #8472939 -
Flags: review?(aki) → review+
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker-profile-2
https://github.com/mozilla/webmaker-profile-2/commit/98d57361156e0eca8e69afe4dfdb79b63f475eb5
Fixed Bug 1053743
Fixed Bug 1053743
Fixed Bug 1053743
https://github.com/mozilla/webmaker-profile-2/commit/7a2c490cff178188b89f29250cdb5aeff52d6cef
Merge pull request #78 from tanay1337/master
Fixes Bug 1053743 - Localize content in app/index.html
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•