1053796 - TokBox SDK logging is enabled by default

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

I'm currently debugging non-SDK related issues on the Loop conversation windows.

This is made harder by the amount of debug logging from the SDK.

Looking at the SDK, it should in theory be turned off by default:

http://hg.mozilla.org/mozilla-central/annotate/5299864050ee/browser/components/loop/content/shared/libs/sdk.js#l19

The problem is that here:

http://hg.mozilla.org/mozilla-central/annotate/5299864050ee/browser/components/loop/content/shared/libs/sdk.js#l2950

The check is done as a boolean, and so 'false' doesn't evaluate to false.

I think there are two things to do here:

1) Please can TokBox fix the SDK detection? (setting needinfo)
2) In the desktop browser, we can implement a pref to turn it back on when we need it.

Comment 1

[song]

You can turn off logging by settingLogLevel: 
OT.setLogLevel(OT.NONE);

Documentation: https://tokbox.com/opentok/libraries/client/js/reference/OT.html#setLogLevel

Will this work for you?

Comment 2

[Mark Banner (:standard8)]

(In reply to song from comment #1)
> You can turn off logging by settingLogLevel: 
> OT.setLogLevel(OT.NONE);
...
> Will this work for you?

Yes it does work, although it still prints out the Tokbox headers for now.

Comment 3

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #2)
> (In reply to song from comment #1)
> > You can turn off logging by settingLogLevel: 
> > OT.setLogLevel(OT.NONE);
> ...
> > Will this work for you?
> 
> Yes it does work, although it still prints out the Tokbox headers for now.

To clarify: it does work, although the "headers" still get dumped:

"TB.setLogLevel(5)"
"OpenTok JavaScript library v2.2.7.2"
"Release notes: http://www.tokbox.com/opentok/webrtc/docs/js/release-notes.html"
"Known issues: http://www.tokbox.com/opentok/webrtc/docs/js/release-notes.html#knownIssues"
"OT.setLogLevel(5)"

What I'd like to know is, will this be fixed in a future version of the SDK? The SDK obviously isn't doing what it is intended at the moment (no debug).

If it is going to be fixed, I can hold-off on changing our code.

Comment 4

[song]

The problem is that the logs are getting printed out before the loglevel is set. However, we have fixed this and the fix will be available in the next release of the SDK.

Comment 5

[Mark Banner (:standard8)]

Ok, thanks, I'll wait until the next release.

Comment 6

[Mark Banner (:standard8)]

The update to 2.2.9 has fixed this. Thanks.

Comment 7

[u279076]

Untracking for QE verification. Please needinfo me to request testing.