[Homescreen] [SingleVariant] SV Apps are installed at the end of the grid instead of on their valid positions

RESOLVED FIXED

Status

Firefox OS
Gaia::Homescreen
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Carmen Jimenez Cabezas, Assigned: Carmen Jimenez Cabezas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
STR:

1. Prepare a build with single variant apps, and define specific positions for those apps.
2. Boot with a configured SIM inserted

Expected:
Apps appear on their configured positions

Actual:
Randomly (sometimes, it doesn't happen always) single variant apps appear at the end of the grid.
The problem happens when the apps are installed before the homescreen app is launched (it's more probable to happen if the SIM inserted doesn't have a PIN set)
(Assignee)

Updated

4 years ago
Assignee: nobody → carmen.jimenezcabezas
(Assignee)

Comment 1

4 years ago
Created attachment 8473059 [details] [review]
V1 Proposed patch
Attachment #8473059 - Flags: review?(kgrandon)
Comment on attachment 8473059 [details] [review]
V1 Proposed patch

So I took a look at the code, and it generally looks fine to me. It does seem quite complex though. Without tests, and probably marionette tests, I fear that this could probably break. Though being that this issue was intermittent, I'm not sure how much a marionette test could help here.
Attachment #8473059 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 3

4 years ago
https://github.com/mozilla-b2g/gaia/commit/a3423431fad131396009eb4f2742bb72f19edf89
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.