1053826 - Self-assignment in mock_navigator_moz_wifi_manager.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Max Schaefer]

On line 10 (https://github.com/mozilla-b2g/gaia/blob/master/apps/operatorvariant/test/unit/mock_navigator_moz_wifi_manager.js#L10):

  function mwm_setNetworks(networks) {
    networks = networks;
  }

should be

  function mwm_setNetworks(nw) {
    networks = nw;
  }

or something along those lines.

Comment 1

[Mike Lee [:mlee]]

Hi Carmen,

Can you fix this reported issue?

MockNavigatorMozWifiManager's |setNetwork (networks)| method won't actually save the supplied list of networks as intended. There's also a shared MockNavigatorMozWifiManager [1] that also implements this method but without the problem reported in this bug.

Can you and Jose also say why the operatorvariant [2] and FTU [3][4] tests aren't both using the same shared implementation [1]?

Thanks!
Mike

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/test/unit/mocks/mock_navigator_moz_wifi_manager.js#L21
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/operatorvariant/test/unit/known_networks_customizer_test.js#L5
[3] https://github.com/mozilla-b2g/gaia/blob/master/apps/ftu/test/unit/wifi_test.js#L5
[4] https://github.com/mozilla-b2g/gaia/blob/master/apps/ftu/test/unit/mock_wifi_helper.js#L3

Comment 2

[Carmen Jimenez Cabezas]

I didn't use the shared mock component because it didn't had the functionality I needed and didn't want to impact other tests that relied on the shared mock. 
Since I'm on PTO, will fix only the reported problem here, and will fix the tests to use the shared component (and modify it) when I return from PTO

Comment 3

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 8479821 [details] [review]
V1 Proposed patch

minor polish but needed for clarity, no need for tests as it's just re-naming, thanks.

Comment 5

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/1d8fa902c616baef69d16d7ead20cc07c482d16d