Closed Bug 1053838 Opened 6 years ago Closed 5 years ago
Update GTest for the v2 bundle structure
GTest doesn't currently run with the new v2 bundle structure: /builds/slave/oak-osx64-ntly-000000000000000/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/oak-osx64-ntly-000000000000000/build/testing/gtest/rungtests.py --xre-path=../../dist/bin --symbols-path=../../dist/crashreporter-symbols ../../dist/bin/firefox gtest INFO | Running gtest Couldn't load XPCOM. gtest TEST-UNEXPECTED-FAIL | gtest | test failed with return code 255 make: *** [check] Error 1 make: *** [check] Error 2 program finished with exit code 2 elapsedTime=98.273582 TinderboxPrint: check<br/>4/0 Unknown Error: command finished with exit code: 2
This simply creates two symlinks, dist/Resources and dist/MacOS, that point to dist/bin.
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
This runs GTest out of the .app bundle as discussed via email.
Attachment #8478285 - Attachment is obsolete: true
Comment on attachment 8480694 [details] [diff] [review] Patch Try push is almost completely green, so requesting review (updater xpcshell test failures and gaia python integration test suite failures are handled in separate bugs): https://tbpl.mozilla.org/?tree=Try&rev=7362867ad903
Comment on attachment 8480694 [details] [diff] [review] Patch For a short-term fix, this is fine, but the rsyncing is rather a pain long-term. Ted do you think we should at least have a followup on file to figure out a better way to do this?
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/24e1e95d7af2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment on attachment 8480694 [details] [diff] [review] Patch Clearing the n-i request as the rsync-ing has been moved to the new MacOS-files.in file in bug 1079520.
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
You need to log in before you can comment on or make changes to this bug.