1053838 - Update GTest for the v2 bundle structure.

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Stephen A Pohl [:spohl]]

Attachment: Build log from Oak (refer to "make -k check" towards the bottom)

GTest doesn't currently run with the new v2 bundle structure:

/builds/slave/oak-osx64-ntly-000000000000000/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/oak-osx64-ntly-000000000000000/build/testing/gtest/rungtests.py --xre-path=../../dist/bin --symbols-path=../../dist/crashreporter-symbols ../../dist/bin/firefox
gtest INFO | Running gtest
Couldn't load XPCOM.
gtest TEST-UNEXPECTED-FAIL | gtest | test failed with return code 255
make[1]: *** [check] Error 1
make: *** [check] Error 2
program finished with exit code 2
elapsedTime=98.273582
TinderboxPrint: check<br/>4/0
Unknown Error: command finished with exit code: 2

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Patch

This simply creates two symlinks, dist/Resources and dist/MacOS, that point to dist/bin.

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: Patch

This runs GTest out of the .app bundle as discussed via email.

Comment 3

[Stephen A Pohl [:spohl]]

Comment on attachment 8480694 [details] [diff] [review]
Patch

Try push is almost completely green, so requesting review (updater xpcshell test failures and gaia python integration test suite failures are handled in separate bugs):
https://tbpl.mozilla.org/?tree=Try&rev=7362867ad903

Comment 4

[Benjamin Smedberg]

Comment on attachment 8480694 [details] [diff] [review]
Patch

For a short-term fix, this is fine, but the rsyncing is rather a pain long-term. Ted do you think we should at least have a followup on file to figure out a better way to do this?

Comment 5

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/projects/oak/rev/a524b55321d7

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/24e1e95d7af2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/24e1e95d7af2

Comment 8

[Stephen A Pohl [:spohl]]

Comment on attachment 8480694 [details] [diff] [review]
Patch

Clearing the n-i request as the rsync-ing has been moved to the new MacOS-files.in file in bug 1079520.

Comment 9

[Robert Strong (they/them - no direct email)]

Landed on aurora in the Mac V2 signing combined patch in bug 1047584