Closed Bug 1053838 Opened 6 years ago Closed 5 years ago

Update GTest for the v2 bundle structure.

Categories

(Testing :: General, defect)

x86
macOS
defect
Not set

Tracking

(firefox34 fixed, firefox35 fixed)

RESOLVED FIXED
mozilla35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(2 files, 1 obsolete file)

GTest doesn't currently run with the new v2 bundle structure:

/builds/slave/oak-osx64-ntly-000000000000000/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/oak-osx64-ntly-000000000000000/build/testing/gtest/rungtests.py --xre-path=../../dist/bin --symbols-path=../../dist/crashreporter-symbols ../../dist/bin/firefox
gtest INFO | Running gtest
Couldn't load XPCOM.
gtest TEST-UNEXPECTED-FAIL | gtest | test failed with return code 255
make[1]: *** [check] Error 1
make: *** [check] Error 2
program finished with exit code 2
elapsedTime=98.273582
TinderboxPrint: check<br/>4/0
Unknown Error: command finished with exit code: 2
Blocks: 1053820
No longer blocks: 1047584
Attached patch Patch (obsolete) — Splinter Review
This simply creates two symlinks, dist/Resources and dist/MacOS, that point to dist/bin.
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
This runs GTest out of the .app bundle as discussed via email.
Attachment #8478285 - Attachment is obsolete: true
Comment on attachment 8480694 [details] [diff] [review]
Patch

Try push is almost completely green, so requesting review (updater xpcshell test failures and gaia python integration test suite failures are handled in separate bugs):
https://tbpl.mozilla.org/?tree=Try&rev=7362867ad903
Attachment #8480694 - Flags: review?(benjamin)
Comment on attachment 8480694 [details] [diff] [review]
Patch

For a short-term fix, this is fine, but the rsyncing is rather a pain long-term. Ted do you think we should at least have a followup on file to figure out a better way to do this?
Attachment #8480694 - Flags: review?(benjamin)
Attachment #8480694 - Flags: review+
Attachment #8480694 - Flags: feedback?(ted)
https://hg.mozilla.org/mozilla-central/rev/24e1e95d7af2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Blocks: 1079520
Comment on attachment 8480694 [details] [diff] [review]
Patch

Clearing the n-i request as the rsync-ing has been moved to the new MacOS-files.in file in bug 1079520.
Attachment #8480694 - Flags: feedback?(ted)
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
You need to log in before you can comment on or make changes to this bug.