Remove GrallocTextureHostOGL::ForgetSharedData()

RESOLVED INVALID

Status

()

Core
Graphics: Layers
RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: sotaro, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
GrallocTextureHostOGL::ForgetSharedData() is not necessary for gralloc buffer.

ForgetSharedData() needs to be implemented when there is a case that an actual buffer needs to be deleted by client side since TextureHost is created. gralloc buffer does not have such necessity.
(Reporter)

Comment 1

3 years ago
Created attachment 8473093 [details] [diff] [review]
patch - Remove GrallocTextureHostOGL::ForgetSharedData()
(Reporter)

Comment 2

3 years ago
(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> GrallocTextureHostOGL::ForgetSharedData() is not necessary for gralloc
> buffer.
> 
> ForgetSharedData() needs to be implemented when there is a case that an
> actual buffer needs to be deleted by client side since TextureHost is
> created. gralloc buffer does not have such necessity.

"gralloc buffer does not have such necessity." paret was wrong.
When TextureFlags::DEALLOCATE_CLIENT flag is set, gralloc texture release is triggered from client side. But there is still no necessity to implement ForgetSharedData().
(Reporter)

Comment 3

3 years ago
I changed my mind. It seems better not to remove ForgetSharedData(). Instead, it seems better to implement it correctly. current implementation is not correct.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.