Closed
Bug 1053989
Opened 10 years ago
Closed 10 years ago
OdinMonkey: add Math.clz32 to stdlib
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(1 file)
|
10.19 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
Right now Math.clz32 doesn't appear to be inlined and it's also not included in the asm.js stdlib. For extra points on x86 we should probe for SSE4.1 to see if we can use lzcnt and avoid the branch associated with bsr.
|
||
Comment 1•10 years ago
|
||
Although we may want to keep this open for the lzcnt bits?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
|
Assignee | |
Comment 2•10 years ago
|
||
We can repurpose this bug to just adding clz32 to asm.js.
Status: RESOLVED → REOPENED
Depends on: 995230
Resolution: DUPLICATE → ---
Summary: optimize Math.clz32 → OdinMonkey: add Math.clz32 to stdlib
|
|
Assignee | |
Comment 3•10 years ago
|
||
This can go after the Math stdlib stuff to avoid conflicts.
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8478320 [details] [diff] [review] clz32 Review of attachment 8478320 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #8478320 -
Flags: review?(benj) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c00000be5f34
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c00000be5f34
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•