1054001 - django.conf.urls.defaults warnings

Status: RESOLVED FIXED

(Input Graveyard :: Code Quality, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

If you run Input like this:

    python -W all manage.py runserver

it prints out some stuff that isn't interesting. But then it prints this:

/home/willkg/mozilla/fjord/vendor/src/django/django/conf/urls/defaults.py:3: DeprecationWarning: django.conf.urls.defaults is deprecated; use django.conf.urls instead
  DeprecationWarning)


I did a grep for "django.conf.urls.defaults" and the fjord code is fine, but there's a bunch of stuff in vendor/ that's not fine:

./vendor/src/django-adminplus/adminplus/__init__.py:
   32 :         from django.conf.urls.defaults import patterns, url

./vendor/src/django-browserid/django_browserid/tests/urls.py:
    4 : from django.conf.urls.defaults import include, patterns, url
./vendor/src/django-browserid/django_browserid/urls.py:
   10 :     from django.conf.urls.defaults import patterns, url

./vendor/src/django-celery/djcelery/monproj/urls.py:
    7 :     from django.conf.urls.defaults import (patterns, include, url,  # noqa
./vendor/src/django-celery/djcelery/urls.py:
   19 :     from django.conf.urls.defaults import patterns, url  # noqa

./vendor/src/django-grappelli/grappelli/urls.py:
    8 :     from django.conf.urls.defaults import url, patterns

This one is probably fine:

./vendor/src/django-rest-framework/rest_framework/compat.py:
   22 :     from django.conf.urls.defaults import patterns, url, include


It kind of looks like we need to update the following:

* django-adminplus
* django-browserid
* django-celery (this actually goes away with more recent versions of celery)
* django-grappelli (this is locked to the django version)

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bumping this to 2015q1 because we're out of time for this quarter.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

We're going to need to do this before we can upgrade to Django 1.7.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Looking at this next.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Will Kahn-Greene [:willkg] from comment #0)
> ./vendor/src/django-adminplus/adminplus/__init__.py:
>    32 :         from django.conf.urls.defaults import patterns, url

The version of django-adminplus being used now is fine:

    (fjord)[rlr (bd8af7b...) django-adminplus]$ git grep 'from django.conf.urls'
    adminplus/sites.py:        from django.conf.urls import patterns, url
    test_urlconf.py:from django.conf.urls import patterns, url, include

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

PR for updating django-browserid to v0.11:
https://github.com/mozilla/fjord/pull/458

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

The instances of `from django.conf.urls.defaults import` in the django-celery we are currently using are just fallbacks for backwards compatibility.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #6)
> The instances of `from django.conf.urls.defaults import` in the
> django-celery we are currently using are just fallbacks for backwards
> compatibility.

And... same thing with django-grapelli. WOOT. Looks like we are good once we get django-browserid upgraded.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Awesome!

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Updated django-browserid in https://github.com/mozilla/fjord/commit/301e9e589e4163fbc0455826bdb0c0cafcd77cdf

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Pretty sure we are done here. My (limited) grep-fu didn't find any more instances and running the devserver I wasn't able to trigger the warning.

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

This was about 2pts

Comment 12

[Will Kahn-Greene [:willkg] ET needinfo? me]

At worst, we'll find out we missed something when we upgrade, but it'll likely be pretty minimal.

You rock!