Browser chrome-related options should be on by default in browser toolbox

RESOLVED FIXED in Firefox 34

Status

()

Firefox
Developer Tools: Framework
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jsantell, Assigned: jryans)

Tracking

unspecified
Firefox 34
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

When using performance debugging chrome, I want gecko platform data, or otherwise why would I use browser toolbox for this -- had to ask around for the answer which wasn't obvious at all
Agreed.  Plus we should set the 'Show Browser Styles' pref on by default in the browser toolbox for the same reason.
I'm not sure exactly how this will be implemented, since the options panel / tools are just reading prefs.  Ryan, is there a way to detect that we are in the Browser Toolbox on startup and then maybe we could set a couple of prefs immediately?
Flags: needinfo?(jryans)
(Assignee)

Comment 3

4 years ago
Created attachment 8473957 [details] [diff] [review]
Set chrome prefs in Browser Toolbox

We can just force them on at startup for the Browser Toolbox.

Try: https://tbpl.mozilla.org/?tree=Try&rev=576938ddc5d9
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8473957 - Flags: review?(bgrinstead)
Flags: needinfo?(jryans)
Comment on attachment 8473957 [details] [diff] [review]
Set chrome prefs in Browser Toolbox

Review of attachment 8473957 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.  Can't remember if there is test coverage for this window, but may add a check there if so.
Attachment #8473957 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 5

4 years ago
(In reply to Brian Grinstead [:bgrins] from comment #4)
> Comment on attachment 8473957 [details] [diff] [review]
> Set chrome prefs in Browser Toolbox
> 
> Review of attachment 8473957 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Works for me.  Can't remember if there is test coverage for this window, but
> may add a check there if so.

I don't believe there is, unfortunately.
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Component: Developer Tools: Profiler → Developer Tools: Framework
Summary: "Show Gecko Platform Data" should be on by default in browser toolbox → Browser chrome-related options should be on by default in browser toolbox
https://hg.mozilla.org/integration/fx-team/rev/0771b6457105
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]

Comment 7

4 years ago
https://hg.mozilla.org/mozilla-central/rev/0771b6457105
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.