Closed Bug 1054014 Opened 10 years ago Closed 10 years ago

Build bustage in nsTextStore, no return at the end of GetGUIDNameStrWithTable

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

nsTextStore-buildfix
1.30 KB, patch
masayuki
: review+
Details | Diff | Splinter Review 
Another build bustage from bug 1040124 - GetGUIDNameStrWithTable doesn't always return a value.
Assignee: nobody → benjamin
Status: NEW → ASSIGNED

        Attachment #8473237 -
        Flags: review?(masayuki)

    
    

    
  
Comment on attachment 8473237 [details] [diff] [review]
nsTextStore-buildfix

Ugh, thanks. But I wonder what's your environment? VS2012 or VS2013 can treat this as error? 2011 isn't so...

        Attachment #8473237 -
        Flags: review?(masayuki) → review+

    
    

    
  
This is VC2013. I'm not sure whether this is a warning-as-error or just an error.

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/06bbefba94d9
Target Milestone: --- → mozilla34

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/06bbefba94d9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: