Closed Bug 1054080 Opened 11 years ago Closed 11 years ago

Fix places tests with promise rejection change

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1053809

People

(Reporter: jsantell, Assigned: jsantell)

Details

Attachments

(1 file)

GH PR 1587
46 bytes, text/x-github-pull-request
evold
: review+
Details | Review
TEST-UNEXPECTED-FAIL | places/main.test bookmark-item-changed | There was an uncaught Promise rejection: JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpRNb1bw.mozrunner/extensions/test-places@jetpack.xpi!/bootstrap.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.test-places-at-jetpack.commonjs.path/sdk/places/host/host-bookmarks.js :: createBookmarkItem :: line 93 Occuring due to test finishing before the createBookmarkItem would be finished, due to sdk/places/events observer events being synchronous
Attached file GH PR 1587 —
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8473337 - Flags: review?(evold)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Comment on attachment 8473337 [details] [review] GH PR 1587 might as well land the test comment change.
Attachment #8473337 - Flags: review?(evold) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: