Block reading buffered ranges until MP4 dexmuxer has initialised

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ajones, Assigned: ajones)

Tracking

(Blocks 1 bug)

Trunk
mozilla34
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Fix the race condition where we try to calculate the buffered ranges off the main thread before we've finished initialising the demuxer.
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Comment on attachment 8474288 [details] [diff] [review]
Fix MP4 demuxer is init vs buffered range race

Review of attachment 8474288 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/fmp4/MP4Reader.cpp
@@ +815,2 @@
>    resource->Pin();
> +  nsresult res = resource->GetCachedRanges(ranges);

Super minor point: |nsresult| is usually named |rv|.
Attachment #8474288 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/28a26c0a23b0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.