105418 - Sample plugin no longer works

Status: RESOLVED INVALID

(Core Graveyard :: Plug-ins, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

The simple sample plugin no longer works on Linux.  Works correctly on Windows.

Build the sample (modules/plugin/samples/simple), and open SimpleScriptableTest.html

As you click on the "Set" and "Get" buttons, no text is displayed in the plugin
region.  The plugin region is allocated correctly - but no text is ever displayed.

I have tracked it down to:
http://lxr.mozilla.org/seamonkey/source/modules/plugin/samples/simple/npsimple.cpp#1021

Function SimplePluginInstance::Repaint(void)

The function gtk_label_set_text() is called with the correct text - but nothing
is displayed.  I have no idea why not.

Comment 1

[James Henstridge]

It looks like the gtk code is trying to emulate what the windows code does
(handle repaints manually).  However, the GtkLabel widget handles it's own
repaints, and setting the label text during an expose is almost certainly broken.

Either the gtk code shouldn't be using a GtkLabel, and manually draw in response
to an expose_event, or it should set the GtkLabel's text once in
SimplePluginInstance::SetText, and not handle exposures at all (letting GtkLabel
do its job).

Comment 2

[Peter Lubczynski]

cc:ing Serge who worked on the sample and Syd the GTK-god.

Comment 3

[av (gone)]

--- Mass reassigning Unix bugs to serge ---

Comment 4

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 5

[rubydoo123]

this is based on xpcom which has since been deprecated, marking invalid