1054189 - All l10n tests are failing with "node is not defined" in localization.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

19:34:55 ERROR | Test Failure | {
19:34:55   "exception": {
19:34:55     "message": "node is not defined", 
19:34:55     "lineNumber": 179, 
19:34:55     "name": "ReferenceError", 
19:34:55     "fileName": "resource://mozmill/stdlib/securable-module.js -> file:///Users/mozauto/jenkins/workspace/mozilla-aurora_l10n/data/mozmill-tests/lib/localization.js"
19:34:55   }
19:34:55 }

Affected line of code:
http://hg.mozilla.org/qa/mozmill-tests/file/9aa710530a34/lib/localization.js#l179

Looks like there is the 'a' prefix missing, which was done via bug

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We will have to get this bustage fixed ASAP. So I will take it.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This failure went unnoticed in Mozmill CI production for 9 days! I can't mention it enough that we have to check for results, and especially really run all of the testruns, which get code changes.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bustage fix v1

Landed bustage fix as:

https://hg.mozilla.org/qa/mozmill-tests/rev/e27a004684b5
https://hg.mozilla.org/qa/mozmill-tests/rev/8262418093c0