Show pressed state on edit mode's cancel button

RESOLVED FIXED in Firefox 34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 34
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

5 years ago
No description provided.
Assignee

Updated

5 years ago
Attachment #8473669 - Flags: review?(michael.l.comella)
Assignee

Comment 3

5 years ago
Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

No need to use margins to align the url entry and the translating view. Simply use alignRight.
Attachment #8473670 - Flags: review?(michael.l.comella)
Assignee

Comment 4

5 years ago
Comment on attachment 8473669 [details] [diff] [review]
Show pressed state on edit mode's cancel button (r=mcomella)

Redirecting to margaret to get earlier review.
Attachment #8473669 - Flags: review?(michael.l.comella) → review?(margaret.leibovic)
Assignee

Comment 5

5 years ago
Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

Ditto.
Attachment #8473670 - Flags: review?(michael.l.comella) → review?(margaret.leibovic)

Updated

5 years ago
Attachment #8473669 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

Review of attachment 8473670 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not completely familiar with how this translation works, but this looks like a reasonable change (I'm usually in favor of any change that removes a hard-coded margin value).
Attachment #8473670 - Flags: review?(margaret.leibovic) → review+
Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e
Assignee

Comment 9

5 years ago
The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/23edbe5bd37d
https://hg.mozilla.org/integration/fx-team/rev/7bba7a71eadf
https://hg.mozilla.org/mozilla-central/rev/23edbe5bd37d
https://hg.mozilla.org/mozilla-central/rev/7bba7a71eadf
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.