Closed Bug 1054264 Opened 6 years ago Closed 6 years ago

Show pressed state on edit mode's cancel button

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 34

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(2 files)

No description provided.
Attachment #8473669 - Flags: review?(michael.l.comella)
Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

No need to use margins to align the url entry and the translating view. Simply use alignRight.
Attachment #8473670 - Flags: review?(michael.l.comella)
Comment on attachment 8473669 [details] [diff] [review]
Show pressed state on edit mode's cancel button (r=mcomella)

Redirecting to margaret to get earlier review.
Attachment #8473669 - Flags: review?(michael.l.comella) → review?(margaret.leibovic)
Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

Ditto.
Attachment #8473670 - Flags: review?(michael.l.comella) → review?(margaret.leibovic)
Attachment #8473669 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

Review of attachment 8473670 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not completely familiar with how this translation works, but this looks like a reasonable change (I'm usually in favor of any change that removes a hard-coded margin value).
Attachment #8473670 - Flags: review?(margaret.leibovic) → review+
Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e
The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/23edbe5bd37d
https://hg.mozilla.org/integration/fx-team/rev/7bba7a71eadf
https://hg.mozilla.org/mozilla-central/rev/23edbe5bd37d
https://hg.mozilla.org/mozilla-central/rev/7bba7a71eadf
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.