1054264 - Show pressed state on edit mode's cancel button

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Show pressed state on edit mode's cancel button (r=mcomella)

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Fix slight overlap between translage edge and cancel button (r=mcomella)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

No need to use margins to align the url entry and the translating view. Simply use alignRight.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8473669 [details] [diff] [review]
Show pressed state on edit mode's cancel button (r=mcomella)

Redirecting to margaret to get earlier review.

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

Ditto.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8473670 [details] [diff] [review]
Fix slight overlap between translage edge and cancel button (r=mcomella)

Review of attachment 8473670 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not completely familiar with how this translation works, but this looks like a reasonable change (I'm usually in favor of any change that removes a hard-coded margin value).

Comment 7

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/5083e681191a
https://hg.mozilla.org/integration/fx-team/rev/9e0e63359e77

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e

Comment 9

[Lucas Rocha (:lucasr)]

The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/23edbe5bd37d
https://hg.mozilla.org/integration/fx-team/rev/7bba7a71eadf

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/23edbe5bd37d
https://hg.mozilla.org/mozilla-central/rev/7bba7a71eadf