Rework LinkAnnotationFilter to issue one DB query for the document

RESOLVED FIXED

Status

Mozilla Developer Network
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jezdez, Unassigned)

Tracking

Details

(Whiteboard: [specification][type:change])

(Reporter)

Description

3 years ago
What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
Currently, LinkAnnotationFilter (https://github.com/mozilla/kuma/blob/745c10a54e163dc3d3374d23d17464be303a9a7e/apps/wiki/content.py#L360) issues a separate DB query for nearly every link on a wiki page.

The awfulness of this had at one point been hidden behind memcache, because the existence-state of each locale/slug pair was individually cached. But, even as I noted in a TODO at the time (https://github.com/mozilla/kuma/blob/745c10a54e163dc3d3374d23d17464be303a9a7e/apps/wiki/content.py#L446), this should be bundled up into fewer DB queries, using the IN clause.

See https://github.com/mozilla/kuma/issues/2062 for the rest of the discussion

What problems would this solve?
===============================
Fewer database queries

Who would use this?
===================
backend

What would users see?
=====================
Faster turn-around for kumascript

What would users do? What would happen as a result?
===================================================
Enjoy the speed

Is there anything else we should know?
======================================
(Reporter)

Comment 1

2 years ago
This was fixed in https://github.com/mozilla/kuma/commit/4e080097e38e7382b2d94b46e77e266d6a52863d and other commits.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.