1054283 - Messaging app should use the new overflow menu component

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Chris Lord [:cwiiis]]

UX would like the overflow menu in the messaging app to match the one in the browser. To enable this, I've split out the markup/code for that into its own shared component, which can be used by messaging in bug 1054274.

I'll probably implement this, but not immediately assigning as I'm going on PTO today and I don't want this to get forgotten if I don't quite manage it before the day ends :)

Comment 1

[Chris Lord [:cwiiis]]

Initial problems with this; there are no icons for all the actions, and sometimes the overflow menu has a header. So some UX work may be required here.

For now, I'm just going to ignore the header and not have icons.

Comment 2

[Chris Lord [:cwiiis]]

This is more work than I anticipated, and requires some UX work that isn't going to get down in the next 2 hours :)

Here's my WIP branch: https://github.com/Cwiiis/gaia/tree/bug1054283-sms-use-overflow-menu

It's missing cancel handlers, but that's the only major thing. It ignores menu headers and sections and doesn't have any icons.

Someone else should be able to pick this up easily if it needs to get done soon, otherwise I'll pick it back up again when I get back (n?myself for this).

Comment 3

[Eric Pang [:epang] UX]

(In reply to Chris Lord [:cwiiis] from comment #1)
> Initial problems with this; there are no icons for all the actions, and
> sometimes the overflow menu has a header. So some UX work may be required
> here.
> 
> For now, I'm just going to ignore the header and not have icons.

Hi Fang, can you take a look at this and see if you think it makes sense to have icons for the menu items?
You can see what we did in browser here: https://mozilla.box.com/s/r36n5hqu8ji0rppo2e1j

Thanks!

Comment 4

[Eric Pang [:epang] UX]

(In reply to Chris Lord [:cwiiis] from comment #2)
> This is more work than I anticipated, and requires some UX work that isn't
> going to get down in the next 2 hours :)
> 
> Here's my WIP branch:
> https://github.com/Cwiiis/gaia/tree/bug1054283-sms-use-overflow-menu
> 
> It's missing cancel handlers, but that's the only major thing. It ignores
> menu headers and sections and doesn't have any icons.
> 
> Someone else should be able to pick this up easily if it needs to get done
> soon, otherwise I'll pick it back up again when I get back (n?myself for
> this).

Hi Jenny,

Do you think the headers and cancel buttons are needed in the menu?  In browser we decided not to include them.  Instead of a cancel button the user presses anywhere outside of the menu or the icon to close.  What do you think?  Thanks!

Comment 5

[Julien Wajsberg [:julienw]]

What is the "overflow menu"? :)

Comment 6

[Chris Lord [:cwiiis]]

(In reply to Julien Wajsberg [:julienw] from comment #5)
> What is the "overflow menu"? :)

The three dots that you tap in the app header that opens up a menu.

Comment 7

[Jenny Lee]

Hello Eric, is the new browser overflow menu gonna land in 2.1 as a common component? 
I think message overflow menu should follow the style specified by building block. Thanks :)

(In reply to Eric Pang [:epang] from comment #4)
> (In reply to Chris Lord [:cwiiis] from comment #2)
> > This is more work than I anticipated, and requires some UX work that isn't
> > going to get down in the next 2 hours :)
> > 
> > Here's my WIP branch:
> > https://github.com/Cwiiis/gaia/tree/bug1054283-sms-use-overflow-menu
> > 
> > It's missing cancel handlers, but that's the only major thing. It ignores
> > menu headers and sections and doesn't have any icons.
> > 
> > Someone else should be able to pick this up easily if it needs to get done
> > soon, otherwise I'll pick it back up again when I get back (n?myself for
> > this).
> 
> Hi Jenny,
> 
> Do you think the headers and cancel buttons are needed in the menu?  In
> browser we decided not to include them.  Instead of a cancel button the user
> presses anywhere outside of the menu or the icon to close.  What do you
> think?  Thanks!

Comment 8

[Fang Shih [:fang]]

(In reply to Eric Pang [:epang] from comment #3)
> (In reply to Chris Lord [:cwiiis] from comment #1)
> > Initial problems with this; there are no icons for all the actions, and
> > sometimes the overflow menu has a header. So some UX work may be required
> > here.
> > 
> > For now, I'm just going to ignore the header and not have icons.
> 
> Hi Fang, can you take a look at this and see if you think it makes sense to
> have icons for the menu items?
> You can see what we did in browser here:

> https://mozilla.box.com/s/r36n5hqu8ji0rppo2e1j
> 
> Thanks!


Hi Eric, it makes sense, so I guess we're going to have an icon for each item in all the overflow menu?

Comment 9

[Harly Hsu[:harly]]

Hi Chris & Eric,
I brought this up to the UX framework meeting today, and it's agree that since the overflow menu is not a web component yet; therefore, for 2.1 we will keep it as it is right now, and will apply the new overflow menu once it becomes a web component. Thanks.

Comment 10

[Chris Lord [:cwiiis]]

(In reply to Harly Hsu from comment #9)
> Hi Chris & Eric,
> I brought this up to the UX framework meeting today, and it's agree that
> since the overflow menu is not a web component yet; therefore, for 2.1 we
> will keep it as it is right now, and will apply the new overflow menu once
> it becomes a web component. Thanks.

It's likely that this will be a web component in 2.1; that's covered in bug 1054274 (which this bug is dependent on).

Clearing my needinfo for now, pending the information required to fulfil this bug.

Comment 11

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 12

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(