Closed Bug 1054304 Opened 5 years ago Closed 5 years ago

Mochitest's TestRunner.js logs an invalid subtest status

Categories

(Testing :: Mochitest, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox33 fixed, firefox34 fixed)

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: chmanchester, Assigned: akachkach)

References

Details

Attachments

(1 file)

TestRunner.js logs an expected subtest status of "OK" in a testStatus call when test URLs get out of sync here: http://hg.mozilla.org/mozilla-central/file/5327d2c8ee54/testing/mochitest/tests/SimpleTest/TestRunner.js#l691 "OK" isn't a valid subtest status, so an exception is thrown, see https://bugzilla.mozilla.org/show_bug.cgi?id=1050251#c9
"ERROR" also isn't a valid status. I wonder if this shouldn't be a testEnd message (as seen in bug 1051635), but maybe it's better to replace "OK" by "PASS" and "ERROR" with "FAIL" For now as the test could've been ended previously.
Assignee: nobody → akachkach
Status: NEW → ASSIGNED
Comment on attachment 8473743 [details] [diff] [review]
0001-Bug-1054304-correct-test-status-for-tests-that-do-no.patch

Review of attachment 8473743 [details] [diff] [review]:
-----------------------------------------------------------------

Like we talked about a bit there's a pending issue of whether this really should be a test_end, but this will fix the invalid subtest status error in the meantime.
Attachment #8473743 - Flags: review?(cmanchester) → review+
Thanks for the review!
Keywords: checkin-needed
Blocks: 886570
https://hg.mozilla.org/mozilla-central/rev/4d72b6b1bfcd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.