Closed Bug 1054318 Opened 5 years ago Closed 5 years ago

Replace multiple addresses in paths when diffing memory reports

Categories

(Toolkit :: about:memory, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

When doing memory report diffs, the differ replaces addresses with 0xNNN. But
it currently only does that for the first address in a path, and sometimes
there is more than one. (I stumbled across this when I was using the differ in
earnest.)
Attachment #8473715 - Flags: review?(erahm)
Comment on attachment 8473715 [details] [diff] [review]
Replace multiple addresses in paths when diffing memory reports

Review of attachment 8473715 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. I think we might want to do this with pids as well, but that could be a separate bug.
Attachment #8473715 - Flags: review?(erahm) → review+
> I think we might want to do this with pids as well, but that could be a separate bug.

I'll just do it now. Likewise for the moz-nullprincipal UUIDs. Probably not necessary, but might save us revisiting this unnecessarily in the future.
https://hg.mozilla.org/mozilla-central/rev/f2d2bc1b2f4b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.