Valgrind is built even when B2G_VALGRIND=0

RESOLVED FIXED in 2.1 S5 (26sep)

Status

Firefox OS
GonkIntegration
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wcosta, Assigned: wcosta)

Tracking

unspecified
2.1 S5 (26sep)
All
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8473718 [details] [review]
Fix: do not build valgrind when B2G_VALGRIND=0

Currently, even when B2G_VALGRIND is 0, valgrind support is built. This happens because build scripts test only if it empty.
(Assignee)

Updated

4 years ago
Attachment #8473718 - Flags: review?(dhylands)
Comment on attachment 8473718 [details] [review]
Fix: do not build valgrind when B2G_VALGRIND=0

The updated version looks good to me.
Attachment #8473718 - Flags: review?(dhylands) → review+
(Assignee)

Updated

4 years ago
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gonk-misc/commit/f2f293787d4a86257c9e78a35bd3f73b31b706e2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in before you can comment on or make changes to this bug.