Closed
Bug 1054334
Opened 7 years ago
Closed 7 years ago
Misc code cleanups
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: sunfish, Assigned: sunfish)
Details
Attachments
(6 files)
23.62 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
2.05 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
15.89 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
5.61 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
6.33 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
2.50 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Attached is a series of miscellaneous code-cleanup patches.
Attachment #8473722 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8473723 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8473724 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8473725 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8473726 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8473727 -
Flags: review?(nicolas.b.pierron)
Comment 6•7 years ago
|
||
Comment on attachment 8473722 [details] [diff] [review] unneeded-semicolons.patch Review of attachment 8473722 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/builtin/SIMD.cpp @@ -689,5 @@ > if (args.length() == 2) { > if (!IsVectorObject<V>(args[0]) || !args[1].isInt32()) > return ErrorBadArgs(cx); > > - Elem *val = TypedObjectMemory<Elem *>(args[0]);; Hum … I wonder where are the "case" and "esac". ::: js/src/jsapi.h @@ +1325,1 @@ > #endif luke: Any reason to keep this code around inside a "#if 0" ?
Attachment #8473722 -
Flags: review?(nicolas.b.pierron) → review+
Updated•7 years ago
|
Attachment #8473723 -
Flags: review?(nicolas.b.pierron) → review+
Updated•7 years ago
|
Attachment #8473724 -
Flags: review?(nicolas.b.pierron) → review+
Updated•7 years ago
|
Attachment #8473725 -
Flags: review?(nicolas.b.pierron) → review+
Updated•7 years ago
|
Attachment #8473726 -
Flags: review?(nicolas.b.pierron) → review+
Comment 7•7 years ago
|
||
Comment on attachment 8473722 [details] [diff] [review] unneeded-semicolons.patch Review of attachment 8473722 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsapi.h @@ +1325,1 @@ > #endif luke> nbp: heh, no, it looks like some a mistake to leave that in luke> nbp: actually, it seems better to use MOZ_STACK_CLASS
Comment 8•7 years ago
|
||
Comment on attachment 8473727 [details] [diff] [review] const-gnostring.patch Review of attachment 8473727 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/xpconnect/src/XPCJSID.cpp @@ +25,5 @@ > > nsJSID::nsJSID() > + : mID(GetInvalidIID()), > + mNumber(const_cast<char *>(gNoString)), > + mName(const_cast<char *>(gNoString)) I am not a big fan of the const_cast, as it often hide mistakes. But I did not spot any location where the content of mNumber / mName is mutated, and if ever it is, this will cause a SEGV as the gNoString would be mapped as read-only. It might be better to change nsJSID to reflect that even if the pointer are mutable their target is not.
Attachment #8473727 -
Flags: review?(nicolas.b.pierron) → review+
Comment 9•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e682602319be https://hg.mozilla.org/mozilla-central/rev/80db0e307d6d https://hg.mozilla.org/mozilla-central/rev/c9b218c047fa https://hg.mozilla.org/mozilla-central/rev/b01844af31c9 https://hg.mozilla.org/mozilla-central/rev/3074b8e53bc6 https://hg.mozilla.org/mozilla-central/rev/a14312d5203e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•7 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•