Closed Bug 1054397 Opened 6 years ago Closed 6 years ago

Test followup to bug 1052545: automated test for experiment branch switching

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

31 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

This a followup to bug 1052545 comment 13: we can probably add an automated test for this by introducing a test-only delay into atomicWrite.
Flags: firefox-backlog+
QA Whiteboard: [qa?]
Iteration: --- → 34.3
QA Whiteboard: [qa?]
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
Attachment #8480074 - Flags: review?(georg.fritzsche)
Forgot to mention, I verified that this failed before bug 1052545 (with rebasing) and passes after. Try run is green: https://tbpl.mozilla.org/?tree=Try&rev=1d406b5db19b
Comment on attachment 8480074 [details] [diff] [review]
bug1054397-racytest

Review of attachment 8480074 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/experiments/Experiments.jsm
@@ +328,5 @@
> +  /**
> +   * For testing a race condition, one of the tests delays the callback of
> +   * atomicWrite by replacing this policy function.
> +   */
> +  delayWrite: function(promise) {

We intend this to specifically delay the atomicWrite() of the cache?
If so, we should name (and comment) this so, e.g. |delayCacheWrite()|.

::: browser/experiments/test/xpcshell/test_cacherace.js
@@ +8,5 @@
> +
> +const MANIFEST_HANDLER         = "manifests/handler";
> +
> +const SEC_IN_ONE_DAY  = 24 * 60 * 60;
> +const MS_IN_ONE_DAY   = SEC_IN_ONE_DAY * 1000;

We should really move these to head.js at some point.
Attachment #8480074 - Flags: review?(georg.fritzsche) → review+
https://hg.mozilla.org/integration/fx-team/rev/de171b8c382b
Target Milestone: --- → Firefox 34
https://hg.mozilla.org/mozilla-central/rev/de171b8c382b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.