Closed
Bug 1054397
Opened 10 years ago
Closed 10 years ago
Test followup to bug 1052545: automated test for experiment branch switching
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
9.95 KB,
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
This a followup to bug 1052545 comment 13: we can probably add an automated test for this by introducing a test-only delay into atomicWrite.
Flags: firefox-backlog+
Updated•10 years ago
|
QA Whiteboard: [qa?]
Updated•10 years ago
|
Iteration: --- → 34.3
QA Whiteboard: [qa?]
Flags: qe-verify?
Updated•10 years ago
|
Flags: qe-verify? → qe-verify-
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8480074 -
Flags: review?(georg.fritzsche)
Assignee | ||
Comment 2•10 years ago
|
||
Forgot to mention, I verified that this failed before bug 1052545 (with rebasing) and passes after. Try run is green: https://tbpl.mozilla.org/?tree=Try&rev=1d406b5db19b
Comment 3•10 years ago
|
||
Comment on attachment 8480074 [details] [diff] [review] bug1054397-racytest Review of attachment 8480074 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/experiments/Experiments.jsm @@ +328,5 @@ > + /** > + * For testing a race condition, one of the tests delays the callback of > + * atomicWrite by replacing this policy function. > + */ > + delayWrite: function(promise) { We intend this to specifically delay the atomicWrite() of the cache? If so, we should name (and comment) this so, e.g. |delayCacheWrite()|. ::: browser/experiments/test/xpcshell/test_cacherace.js @@ +8,5 @@ > + > +const MANIFEST_HANDLER = "manifests/handler"; > + > +const SEC_IN_ONE_DAY = 24 * 60 * 60; > +const MS_IN_ONE_DAY = SEC_IN_ONE_DAY * 1000; We should really move these to head.js at some point.
Attachment #8480074 -
Flags: review?(georg.fritzsche) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/de171b8c382b
Target Milestone: --- → Firefox 34
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de171b8c382b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•