Closed Bug 1054409 Opened 5 years ago Closed 5 years ago

[AccessFu] Add isFromUserInput to pivot change presentation

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: eeejay, Assigned: eeejay)

Details

Attachments

(2 files)

Comment on attachment 8473785 [details] [diff] [review]
Add isFromUserInput to pivot change presentation

Review of attachment 8473785 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one nit. Thanks!

::: accessible/jsat/Presentation.jsm
@@ +45,5 @@
>     * @param {PivotContext} aContext the context object for the new pivot
>     *   position.
>     * @param {int} aReason the reason for the pivot change.
>     *   See nsIAccessiblePivot.
> +   * @param {bool} aIsFromUser the pivot change was invoked by the user

Nit for this whole file. lets call the arg aIsFromUserInput to be consistent with the name in the detail and across all presentations (here and B2G).
Attachment #8473785 - Flags: review?(yzenevich) → review+
This wasn't at fault (no compiled files even). Re-landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/997c9af10dec
https://hg.mozilla.org/mozilla-central/rev/997c9af10dec
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.