Closed
Bug 1054409
Opened 10 years ago
Closed 10 years ago
[AccessFu] Add isFromUserInput to pivot change presentation
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8473785 -
Flags: review?(yzenevich)
Comment 2•10 years ago
|
||
Comment on attachment 8473785 [details] [diff] [review] Add isFromUserInput to pivot change presentation Review of attachment 8473785 [details] [diff] [review]: ----------------------------------------------------------------- r=me with one nit. Thanks! ::: accessible/jsat/Presentation.jsm @@ +45,5 @@ > * @param {PivotContext} aContext the context object for the new pivot > * position. > * @param {int} aReason the reason for the pivot change. > * See nsIAccessiblePivot. > + * @param {bool} aIsFromUser the pivot change was invoked by the user Nit for this whole file. lets call the arg aIsFromUserInput to be consistent with the name in the detail and across all presentations (here and B2G).
Attachment #8473785 -
Flags: review?(yzenevich) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/62d9d374cd0f
Assignee: nobody → eitan
Comment 4•10 years ago
|
||
Backed out for windows non-unified bustage https://hg.mozilla.org/integration/mozilla-inbound/rev/2d7cc0aef9f9
Comment 5•10 years ago
|
||
This wasn't at fault (no compiled files even). Re-landed. https://hg.mozilla.org/integration/mozilla-inbound/rev/997c9af10dec
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/997c9af10dec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•