Closed
Bug 1054457
Opened 10 years ago
Closed 10 years ago
[Search] Visual Refinements for Rocket Bar Search Results screen
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(b2g-v2.1 fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S4 (12sep)
People
(Reporter: epang, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
User Story
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
crdlc
:
review+
bajaj
:
approval-gaia-v2.1+
|
Details | Review |
We're hoping to have 3 line labels in the search app for 2.1. Also, there are some alignment changes which are covered in the spec.
Updated•10 years ago
|
Blocks: rocketbar-search-mvp
Updated•10 years ago
|
No longer blocks: browser-chrome-mvp
Assignee | ||
Comment 1•10 years ago
|
||
Eric - I'm a bit confused, it seems that the attached spec only has 2 rows. Was this a spec for 2.0? Do we have anything that illustrates 2.1, or should we attempt to increase it by ~1.4rem to accommodate the extra line of text?
Flags: needinfo?(epang)
Reporter | ||
Comment 2•10 years ago
|
||
Hey Kevin, Sorry about that, the link was pulling the 2.0 spec. Here's a link to the 2.1 spec https://mozilla.box.com/s/o9gbtnq3ttmfq2beoch6 Thanks!
User Story: (updated)
Flags: needinfo?(epang) → needinfo?(kgrandon)
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → kgrandon
Assignee | ||
Comment 4•10 years ago
|
||
Cristian - would you mind helping me review this code that touches gaia-grid if you have time?
Attachment #8486879 -
Flags: review?(crdlc)
Comment 5•10 years ago
|
||
Comment on attachment 8486879 [details] [review] Github pull request LGTM although there is a comment on github and I would like to add an unit test to test the method "gridItemHeight" with different values of text-rows (e.g. defined or not). Thanks a lot
Attachment #8486879 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Thanks Cristian. I fixed it up to increase height and allow the user to pass any number of rows for height. Also added a unit test.
Assignee | ||
Comment 8•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/bfe4a58d79f581f13faef18dd39c2a3b8c80cd0e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8486879 [details] [review] Github pull request [Approval Request Comment] [Bug caused by] (feature/regressing bug #): This is polish work for a feature. [User impact] if declined: Search results (especially history results), are often truncated. This will help UX. [Testing completed]: Manual and unit tests. [Risk to taking this patch] (and alternatives if risky): The patch is fairly contained to this new polish work, so it should be no/low risk. [String changes made]: None.
Attachment #8486879 -
Flags: approval-gaia-v2.1?(fabrice)
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S4 (12sep)
Updated•10 years ago
|
Attachment #8486879 -
Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Comment 10•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/c8d0f58769637105d385c5b407423d23d0332770
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•