1054457 - [Search] Visual Refinements for Rocket Bar Search Results screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Eric Pang [:epang] UX]

We're hoping to have 3 line labels in the search app for 2.1.  Also, there are some alignment changes which are covered in the spec.

Comment 1

[Kevin Grandon :kgrandon]

Eric - I'm a bit confused, it seems that the attached spec only has 2 rows. Was this a spec for 2.0?

Do we have anything that illustrates 2.1, or should we attempt to increase it by ~1.4rem to accommodate the extra line of text?

Comment 2

[Eric Pang [:epang] UX]

Hey Kevin,

Sorry about that, the link was pulling the 2.0 spec.  Here's a link to the 2.1 spec
https://mozilla.box.com/s/o9gbtnq3ttmfq2beoch6

Thanks!

Comment 3

[Kevin Grandon :kgrandon]

Great, thanks!

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Cristian - would you mind helping me review this code that touches gaia-grid if you have time?

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8486879 [details] [review]
Github pull request

LGTM although there is a comment on github and I would like to add an unit test to test the method "gridItemHeight" with different values of text-rows (e.g. defined or not). Thanks a lot

Comment 6

[Kevin Grandon :kgrandon]

Thanks Cristian. I fixed it up to increase height and allow the user to pass any number of rows for height. Also added a unit test.

Comment 7

[Cristian Rodriguez (:crdlc)]

Excellent!

Comment 8

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/bfe4a58d79f581f13faef18dd39c2a3b8c80cd0e

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8486879 [details] [review]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): This is polish work for a feature.
[User impact] if declined: Search results (especially history results), are often truncated. This will help UX.
[Testing completed]: Manual and unit tests.
[Risk to taking this patch] (and alternatives if risky): The patch is fairly contained to this new polish work, so it should be no/low risk.
[String changes made]: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/c8d0f58769637105d385c5b407423d23d0332770