Closed Bug 1054476 Opened 5 years ago Closed 5 years ago

Clean up services/ Makefiles

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

No description provided.
Naming them as things that rules.mk uses makes things a lot clearer.
Attachment #8473855 - Flags: review?(gps)
Now that our *JS_MODULES support is up to snuff, we can use that for these
installation bits instead.
Attachment #8473856 - Flags: review?(gps)
Attachment #8473855 - Flags: review?(gps) → review+
Comment on attachment 8473856 [details] [diff] [review]
move INSTALL_TARGETS in services/ Makefiles to EXTRA_{PP_,}JS_MODULES

Review of attachment 8473856 [details] [diff] [review]:
-----------------------------------------------------------------

Good riddance.
Attachment #8473856 - Flags: review?(gps) → review+
Comment on attachment 8473855 [details] [diff] [review]
use PREF_JS_EXPORTS in services/ Makefiles

>+++ b/services/common/Makefile.in

>-JS_EXPORTS_FILES := $(srcdir)/services-common.js
>-JS_EXPORTS_DEST = $(FINAL_TARGET)/$(PREF_DIR)
>-INSTALL_TARGETS += JS_EXPORTS
>+PREF_JS_EXPORTS := $(srcdir/services-common.js
Missing closing ) ?
(In reply to Ian Neal from comment #4)
> Comment on attachment 8473855 [details] [diff] [review]
> use PREF_JS_EXPORTS in services/ Makefiles
> 
> >+++ b/services/common/Makefile.in
> 
> >-JS_EXPORTS_FILES := $(srcdir)/services-common.js
> >-JS_EXPORTS_DEST = $(FINAL_TARGET)/$(PREF_DIR)
> >-INSTALL_TARGETS += JS_EXPORTS
> >+PREF_JS_EXPORTS := $(srcdir/services-common.js
> Missing closing ) ?

Ah, you fixed it in the INSTALL_TARGETS patch.
(In reply to Ian Neal from comment #5)
> Ah, you fixed it in the INSTALL_TARGETS patch.

Thanks for the spot, I fixed this up prior to commit.
Assignee: nobody → nfroyd
https://hg.mozilla.org/mozilla-central/rev/85b3a50cd551
https://hg.mozilla.org/mozilla-central/rev/436351a9370a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.