Closed Bug 1054518 Opened 10 years ago Closed 10 years ago

Decide how to handle optional/required parameters to ConversationModel#set{Incoming,Outgoing}SessionData

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Blocking Flags:
backlog Fx37+

People

(Reporter: standard8, Unassigned)

Details

(Whiteboard: [tech-debt]) 

Picked up in the review in bug 1022594 comment 34:

> @@ +25,5 @@
> > +      sessionId:      "sessionId",
> > +      sessionToken:   "sessionToken",
> > +      apiKey:         "apiKey",
> > +      callType:       "callType",
> > +      websocketToken: 123
> 
> The fact that we're not including all of the types that were added elsewhere
> in the patch but the tests are passing makes me slightly concerned that
> we're not testing the right thing here.  If what's actually happening is
> that some stuff is optional and some isn't, and we want to make that
> explicitly checked in the code in the future, a spinoff bug would be nice.
Whiteboard: [tech-debt]
backlog: --- → Fx36+
backlog: Fx36+ → Fx37+
Priority: -- → P1
Summary: Decide if how to handle optional/required parameters to ConversationModel#set{Incoming,Outgoing}SessionData → Decide how to handle optional/required parameters to ConversationModel#set{Incoming,Outgoing}SessionData
We're moving away from ConversationModel in bug 1088672 and at some stage we'll remove the old call url handling code. Hence, this isn't really worth fixing -> wontfix.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.