1054521 - Search app should retain state

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Francis Djabri [:djabber]]

From home screen:

1) Tap on rocket bar
2) Enter in a search term
3) Press home
4) Open an app
5) Tap on rocket bar

Expected: search term should still be there
Actual: search app is empty

According to the Search app spec, the search term should be retained except in the case of a new browser window.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Working on a test now.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8479494 [details] [review]
Github pull request

Looking for a review here if one of you has time. Thanks!

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 8479494 [details] [review]
Github pull request

This feels like a bit of another weird special case, but OK.

I assume it's OK that focusing the Rocketbar from a browser window will clear the search term so that a subsequently focused Rocketbar will be blank.

Comment 4

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/3ffb2e095dd36a700fe7119f317c814be822f0a6

(In reply to Ben Francis [:benfrancis] from comment #3)
> I assume it's OK that focusing the Rocketbar from a browser window will
> clear the search term so that a subsequently focused Rocketbar will be blank.

Yeah, we need to figure that out as well. Looks like we do have bug 1056778 that we also need to solve. I think that these two bugs should be enough to address this?