Closed Bug 1054521 Opened 5 years ago Closed 5 years ago

Search app should retain state

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86
macOS
defect
Not set

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
2.1 S3 (29aug)
tracking-b2g backlog

People

(Reporter: djabber, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
benfrancis
: review+
Details | Review
From home screen:

1) Tap on rocket bar
2) Enter in a search term
3) Press home
4) Open an app
5) Tap on rocket bar

Expected: search term should still be there
Actual: search app is empty

According to the Search app spec, the search term should be retained except in the case of a new browser window.
blocking-b2g: --- → backlog
Whiteboard: systemsfe
See Also: → 1056778
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: systemsfe → [systemsfe]
Target Milestone: --- → 2.1 S3 (29aug)
Attached file Github pull request
Working on a test now.
Comment on attachment 8479494 [details] [review]
Github pull request

Looking for a review here if one of you has time. Thanks!
Attachment #8479494 - Flags: review?(dale)
Attachment #8479494 - Flags: review?(bfrancis)
Comment on attachment 8479494 [details] [review]
Github pull request

This feels like a bit of another weird special case, but OK.

I assume it's OK that focusing the Rocketbar from a browser window will clear the search term so that a subsequently focused Rocketbar will be blank.
Attachment #8479494 - Flags: review?(dale)
Attachment #8479494 - Flags: review?(bfrancis)
Attachment #8479494 - Flags: review+
Master: https://github.com/mozilla-b2g/gaia/commit/3ffb2e095dd36a700fe7119f317c814be822f0a6

(In reply to Ben Francis [:benfrancis] from comment #3)
> I assume it's OK that focusing the Rocketbar from a browser window will
> clear the search term so that a subsequently focused Rocketbar will be blank.

Yeah, we need to figure that out as well. Looks like we do have bug 1056778 that we also need to solve. I think that these two bugs should be enough to address this?
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
See Also: 1056778
Depends on: 1090562
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.