Differential Testing: Different output message involving enumerable

RESOLVED FIXED in mozilla35

Status

()

Core
JavaScript Engine: JIT
--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gkw, Assigned: jandem)

Tracking

(Blocks: 2 bugs, {testcase})

Trunk
mozilla35
x86_64
All
testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1054541 +++

try {
    Object.defineProperty(this, "i", {
        enumerable: (a = this),
        get: function() {
            u
        }
    });
    for each(var e in this);
} catch (e) {}
print(e())


$ ./js-dbg-opt-32-dm-nsprBuild-darwin-174e75a23eaf --fuzzing-safe --ion-offthread-compile=off 232220.js
12

$ ./js-dbg-opt-32-dm-nsprBuild-darwin-174e75a23eaf --fuzzing-safe --ion-offthread-compile=off --ion-eager --no-threads 232220.js
0

Tested this on m-c rev 174e75a23eaf.

My configure flags are:

LD=ld CROSS_COMPILE=1 CC="clang -Qunused-arguments -msse2 -mfpmath=sse -arch i386" RANLIB=ranlib CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments -msse2 -mfpmath=sse" HOST_CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse" sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-debug --enable-optimize --enable-gczeal --enable-debug-symbols --disable-tests --enable-more-deterministic --with-ccache --enable-nspr-build

Jan, any idea what's going on here? Not sure if this is related to bug 1054541.
Flags: needinfo?(jdemooij)
(Assignee)

Comment 1

3 years ago
The problem is that we're calling the helperThreadCount() shell function and it always returns 0 with --no-threads, but something else without that flag.

One option is to always use --no-threads, but then you can no longer do differential testing for PJS code etc. I can also change the helperThreadCount() function to always return 0 in more-deterministic builds. Thoughts?
Flags: needinfo?(jdemooij) → needinfo?(gary)
(Reporter)

Comment 2

3 years ago
(In reply to Jan de Mooij [:jandem] from comment #1)
> I can also change the helperThreadCount() function to always return 0 in more-deterministic
> builds. Thoughts?

This seems like a much better solution. We only run compareJIT differential testing in more-deterministic builds anyway. Thanks! :)
Flags: needinfo?(gary) → needinfo?(jdemooij)
(Assignee)

Comment 3

3 years ago
Created attachment 8481202 [details] [diff] [review]
Patch

Make helperThreadCount() always return 0 in more-deterministic builds.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8481202 - Flags: review?(bhackett1024)
Flags: needinfo?(jdemooij)
Attachment #8481202 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6106415bc7d1
https://hg.mozilla.org/mozilla-central/rev/6106415bc7d1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.