After signing in with Github and connecting with an existing MDN account, send user to Profile page, not Create New Profile Page. After authorizing my Github account (http://cl.ly/image/112H2l443936), I then connected my existing MDN account via the notification banner (http://cl.ly/image/1I1g0O0I0i36) by clicking "Yes, connect with my MDN account". Next, I saw the Create New Profile page asking me to fill in new user info (http://cl.ly/image/01112N3F0i47). I am not a new user, so I am now stuck. I would not expect to see the Create New Profile page that is asking for my username. I already have an MDN username and profile page, which I just told MDN since I went through the Persona sign-in. Part of confirming that we have recognized the user and connected their accounts is not asking them for this information again. There are 3 things I would expect to see here: - Bring me to my existing profile page connected with the Persona acct I just signed into - At the top of this profile page, tell me in the banner notification that the account was connected successfully (in my case, Github + my existing MDN acct). - Instead of “Sign in with…” next to tabzilla (http://cl.ly/image/0g3t1B1J0A1Q), recognize that I have signed in.
This is the bug: 1. Sign in via GitHub 2. Authorize GitHub 3. Click "Connect with my MDN account" 4. Pick a Persona email **that is not an existing MDN account** Actual Results: 5. Get the "Sign Up"/Create New Profile page (Proposed) Expected Results: 5. Go back to the "Sign Up"/Create New Profile page with: * An error message that the Persona email chosen is not a valid MDN account * The same prompt to "Connect with my MDN account" :habber or :shobson - is the proposal good? If so I'll start coding it.
Created attachment 8476112 [details] mdn-github-connect-existing.gif MDN GitHub "Connect with my MDN account" when Persona email address is found.
Created attachment 8476113 [details] mdn-github-connect-not-found.gif MDN GitHub authentication "Connect with my MDN account" when Persona email address is not found.
The proposal sounds good to me. The new error message needs to be red/fail so the user doesn't assume it is the same error and appear further up the page (between the page title and the first heading).
Confirming what Luke says in comment 1. When a user chooses a Persona account that is already associated with an MDN account, they are redirected back to where they came from. They are not shown the "Create new profile" page. When a user chooses a Persona account that is /not/ already associated with an MDN account, they are shown the "Create new profile" page. I'll work on the additional notifications and other UI elements that are needed in both cases.
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/4bda3e4f5faf1cff60caff3df383649c7a381ff9 Bug 1054558: Notification after successful connect If a user tries to authenticate with a service that is not already associated with their account (for example, GitHub) they might be notified that there is already an MDN profile using the same email address. When this happens, the user is given the option of authenticating with a third-party service that /is/ associated with the account (for example, Persona) to make both services (in this case, GitHub and Persona) authentication options for that account. These changes notify the user when this is done successfully. https://github.com/mozilla/kuma/commit/55f58625c59fdb5d8585326269c870b5835056e8 Merge pull request #2719 from openjck/1054558-account-association-feedback Bug 1054558: Notification after successful connect
Luke fixed this along with bug 1063830.