Closed
Bug 105462
Opened 24 years ago
Closed 24 years ago
Get rid of calls to nsIChromeRegistry
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: adamlock, Assigned: adamlock)
Details
Attachments
(1 file)
|
977 bytes,
patch
|
Details | Diff | Splinter Review |
NS_InitEmbedding calls nsIChromeRegistry::CheckForNewChrome() which is an
expensive operation. It shouldn't be necessary to call it as the chrome registry
will set up the chrome if it isn't already.
http://lxr.mozilla.org/mozilla/source/rdf/chrome/src/nsChromeRegistry.cpp#362
Remove the call to this method.
|
||
Updated•24 years ago
|
QA Contact: mdunn → depstein
|
|
||
Comment 2•24 years ago
|
||
That was exactly what I did and found that my embedding app still did chrome.
r=ccarlen
|
|
||
Comment 3•24 years ago
|
||
Do you want this in an #ifdef DEBUG maybe?
|
|
||
Comment 4•24 years ago
|
||
Why would you ever want this in a debug build?
|
|
||
Comment 5•24 years ago
|
||
The entire chrome registry should be a noop for embedding.
|
|
||
Comment 6•24 years ago
|
||
Ccing hyatt. The patch looks good to me. Hyatt is the lord though.
|
|
||
Comment 8•24 years ago
|
||
r/sr=hyatt
Fix is in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•24 years ago
|
||
Verified in 10/19 mozilla nightly build and on lxr. Lines were removed from
nsEmbedAPI.cpp.
Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•