Closed
Bug 1054635
Opened 10 years ago
Closed 10 years ago
[Messages] Context menu/long tap on container area in Composer panel causes javascript error
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.2 S1 (5dec)
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | fixed |
People
(Reporter: azasypkin, Assigned: rishav_, Mentored)
Details
(Whiteboard: [sms-papercuts][lang=js][good first bug])
Attachments
(1 file)
Context menu/long tap on container area in Composer panel causes javascript error
[JavaScript Error: "TypeError: messageBubble is null" {file: app://sms.gaiamobile.org/js/thread_ui.js" line: 1983}]
Haven't noticed any user facing issues though.
|
||
Comment 1•10 years ago
|
||
Would you be willing to mentor a contributor through this?
Flags: needinfo?(azasypkin)
|
||
Updated•10 years ago
|
Mentor: azasypkin
Whiteboard: [sms-papercuts] → [sms-papercuts][lang=js][good first bug]
|
|
||
Updated•10 years ago
|
Flags: needinfo?(azasypkin)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → rishav006
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Hi Juliew As Oleg is on PTO, i asked review from you. Here is the patch. Please have a look :) Thanks
Attachment #8507887 -
Flags: review?(felash)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8507887 [details] [review] Bug 1054635 - Context menu/long tap on container area in Composer panel causes javascript error Please add a unit test :) thanks
Attachment #8507887 -
Flags: review?(felash)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8507887 [details] [review] Bug 1054635 - Context menu/long tap on container area in Composer panel causes javascript error Hi Julien Have a look on PR. Hope it's fine now. Thanks
Attachment #8507887 -
Flags: review?(felash)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8507887 [details] [review] Bug 1054635 - Context menu/long tap on container area in Composer panel causes javascript error r=me thanks :)
Attachment #8507887 -
Flags: review?(felash) → review+
|
|
||
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/9c963e394917bfe49925e403e522fd763d15a306
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S1 (5dec)
|
|
Assignee | |
Updated•9 years ago
|
Summary: Context menu/long tap on container area in Composer panel causes javascript error → [Messages] Context menu/long tap on container area in Composer panel causes javascript error
You need to log in
before you can comment on or make changes to this bug.
Description
•