test-push_printurls.t failing on Linux due to shell syntax

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gps, Unassigned)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
test-push_printurls.t is failing on Linux due to shell syntax that doesn't do the expected thing in older versions of bash.

The test is failing thus:

--- /home/vagrant/version-control-tools/hghooks/tests/test-push_printurls.t
+++ /home/vagrant/version-control-tools/hghooks/tests/test-push_printurls.t.err
@@ -94,7 +94,7 @@
   adding changesets
   adding manifests
   adding file changes
-  added 21 changesets with 21 changes to 1 files
-  You can view the pushlog for your changes at the following URL:
-    https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=77380cff16a1
+  added 1 changesets with 1 changes to 1 files
+  You can view your change at the following URL:
+    https://hg.mozilla.org/integration/mozilla-inbound/rev/786146cc2848
 

ERROR: test-push_printurls.t output changed
(Reporter)

Comment 1

3 years ago
Created attachment 8474139 [details]
Review for review ID: bz://1054668/gps

/r/116 - Bug 1054668 - Use compatible shell syntax in test-push_printurls.t
Attachment #8474139 - Flags: review?(bkero)
(Reporter)

Comment 2

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/abc1c5bdca9b
(Reporter)

Comment 3

3 years ago
Comment on attachment 8474139 [details]
Review for review ID: bz://1054668/gps

Got IRC review from edmorley.
Attachment #8474139 - Flags: review?(bkero)
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.