1054710 - Find Bar - Wrong Match Number

Status: NEW

(Toolkit :: Find Toolbar, defect, P5)

Description

[Yaron]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140814150857

Steps to reproduce:

Open "about:privatebrowsing"
Double-click the word "Firefox" (won't remember etc.).
Open the find bar.


Actual results:

2 out of 2 matches.
Really confusing.


Expected results:

No match is selected by the find bar.
The string should be "0 out of 2 matches" or "2 matches, none selected".

Comment 1

[Itiel]

Yaron, can you verify if this bug still exists and/or you have other STR for this bug?

Comment 2

[Yaron]

Hello Itiel,

This issue still exists.

If you select the *first* "Firefox" occurrence and press Ctrl+F, the result is: "2 out of 2 matches".

It should be: "1 out of 2 matches" (the *first* "Firefox" occurrence has been selected).  

***

As for my statement:
No match is selected by the find bar.
The string should be "0 out of 2 matches" or "2 matches, none selected".

I don't remember the behavior at the time I filed the bug.
As of now (FF 50), the selection is grayed as the Find bar gets the focus.
It's possible that back then the selection disappeared completely (i.e. not even grayed).

Thank you.

Comment 3

[Tomer Cohen :tomer]

(In reply to Yaron from comment #2)
> If you select the *first* "Firefox" occurrence and press Ctrl+F, the result
> is: "2 out of 2 matches".
> 
> It should be: "1 out of 2 matches" (the *first* "Firefox" occurrence has
> been selected).  

Before you start your search, please open the find bad, and make sure it won't remember the previous search. Then double click on a string and open the search bar again ⇒ There is no running search, but the string is copied to the search bar. Press Enter to start the search, and you'll get "Match 1 of 7" as expected.

Comment 4

[Yaron]

Hello Tomer,

Thanks for the workaround. I appreciate it.

Comment 5

[Itiel]

(In reply to Tomer Cohen :tomer from comment #3)
> Before you start your search, please open the find bad, and make sure it
> won't remember the previous search. Then double click on a string and open
> the search bar again ⇒ There is no running search, but the string is copied
> to the search bar. Press Enter to start the search, and you'll get "Match 1
> of 7" as expected.

While this is indeed a workaround, I don't think users need to mess with this stuff all the time. It should simply work.
I think Firefox should auto-clear the previous results (including the "x out of y matches" wording) if a Ctrl-F on a new string is pressed.