1054720 - Placement of the More button is not ideal

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: more button placement.png

steps to reproduce:
1. Load https://marketplace-feed-dev.allizom.org/ with region set to RoW
2. Notice the placement of the 'More' button


expected behavior:
'More' button is centered


actual behavior:
'More' button is on the left

Comment 1

[Kevin Ngo [:ngoke]]

The expected behavior to center it is technically not feasible with Isotope, our layout library. On desktop the More button will go wherever there is the most space available. Of course, it sucks to have it jump around left and right, but it looks visually better than putting it on its own row.

The actual bug should be to implement load-on-scroll ("infinite scrolling"), which is out-of-scope for launch. Since this only affects desktop, I'm opting to ignore it for now.

Comment 2

[krupa raj[:krupa]]

(In reply to Kevin Ngo [:ngoke] from comment #1)
> The expected behavior to center it is technically not feasible with Isotope,
> our layout library. On desktop the More button will go wherever there is the
> most space available. Of course, it sucks to have it jump around left and
> right, but it looks visually better than putting it on its own row.
> 
> The actual bug should be to implement load-on-scroll ("infinite scrolling"),
> which is out-of-scope for launch. Since this only affects desktop, I'm
> opting to ignore it for now.

I disagree. It would look much better if the "more" button was on its own row.

 See https://www.dropbox.com/s/f1itqs6ituoiapm/Screenshot%202014-08-18%2011.33.46.png

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1055160

Comment 3

[Philip [:pwalm]]

I'd say 30 px padding between the bottom of the feed element and the 1px line, 20px between the line and the top of the "more" button, and 30px between the bottom of the button and the top of the footer. If you need me to spec it out visually, let me know.

Comment 4

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/commit/fef758b3cbb5830e7e09662efb54f12f24a6551c

Comment 5

[Kevin Ngo [:ngoke]]

Attachment: postfix

Comment 6

[krupa raj[:krupa]]

verified fixed