GaiaIcons directory is wrongly named

RESOLVED WONTFIX

Status

Firefox OS
Gaia
RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
wilsonpage
: review-
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Our coding standards dictate lowercase_and_underscored filenames. We unfortunately do not yet have a linter for this, but as these components are new, we should strive to follow the convention.

The gaia-icons folder should be renamed to gaia_icons.
(Assignee)

Comment 1

3 years ago
Created attachment 8474280 [details] [review]
Github pull request

Hey Yan, Wilson,

We need to fix these directory paths. Could one of you guys review it? Thanks!
Attachment #8474280 - Flags: review?(yor)
Attachment #8474280 - Flags: review?(wilsonpage)
Comment on attachment 8474280 [details] [review]
Github pull request

kgrandon: It isn't that simple I'm afraid, Bower names these directories, not us. The name is derived from the repo/package name.

It will be far to disruptive to rename the repo/package at this stage, and offers little benefit. It would be a lot easier for us to rename the the other directories in shared/elements/ to use the '-' style, and be the exception to the rule. 

This is partly why I wanted to have a designated 'third-party external components' directory, that wasn't linted or tested inside the Gaia project. Having internal and external components in the same directory is confusing.
Attachment #8474280 - Flags: review?(yor)
Attachment #8474280 - Flags: review?(wilsonpage)
Attachment #8474280 - Flags: review-
(Assignee)

Comment 3

2 years ago
This work isn't important anymore.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.