1054797 - GaiaIcons directory is wrongly named

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

Our coding standards dictate lowercase_and_underscored filenames. We unfortunately do not yet have a linter for this, but as these components are new, we should strive to follow the convention.

The gaia-icons folder should be renamed to gaia_icons.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Yan, Wilson,

We need to fix these directory paths. Could one of you guys review it? Thanks!

Comment 2

[Wilson Page [:wilsonpage]]

Comment on attachment 8474280 [details] [review]
Github pull request

kgrandon: It isn't that simple I'm afraid, Bower names these directories, not us. The name is derived from the repo/package name.

It will be far to disruptive to rename the repo/package at this stage, and offers little benefit. It would be a lot easier for us to rename the the other directories in shared/elements/ to use the '-' style, and be the exception to the rule. 

This is partly why I wanted to have a designated 'third-party external components' directory, that wasn't linted or tested inside the Gaia project. Having internal and external components in the same directory is confusing.

Comment 3

[Kevin Grandon :kgrandon]

This work isn't important anymore.