1054878 - Follow-up of bug 1024298: zh-Pinyin should switch to half-width layout

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

This bug will do the issue 3 in the tracking bug 1054145:

When we are at type="number" input, Pinyin would be launched into full-width symbol panel. It should launch into half-width panel, as specified by UX.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Let's have the bug tested!

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

Rudy, could you review this patch? Thanks!

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Omega,

I'd like to double confirm that the bug is valid -- it is desired that you want zh-Pinyin to be launched into *half-width* symbol panel for type="number" inputs, right?

I'm asking because for normal type="text" inputs, we launch into zh-Pinyin's alphabet panel and when user switches to symbol panel, it is the *full-width* symbol panel that is first presented. So I want to make sure such inconsistency is okay w.r.t. the type="number" spec.

Thanks a lot!

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

NI Omega for comment 3.

Comment 5

[Omega Feng [:Omega] [:馮於懋]]

Hi John, right, it should go to half-width symbol 1 directly in a number input.
Also, Zhuyin should follow this rule. (Zhuyin is now being improved in bug 1019472, but not including the rule you mentioned.)

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

John, Omega, 

Thanks for the confirmation.

In order to make Zhuyin also follow the same behavior, could we generalize this into a property in layout definition file? e.g.
defaultPageforNumber: 'zh-Hans-Pinyin-Symbol-En-1'.

I'll clear the review first.

Comment 7

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Diff between comment 2 and comment 8

Comment 8

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

Hi Rudy,

Could you check the patch again? A diff from last revision is available at attachment 8475786 [details] [diff] [review]. Thanks!

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

John, this looks pretty good to me.
Thank you.

Comment 10

[John Lu [:mnjul][Please NI or I'll miss]]

bug 1024298 got reverted and wontfix'ed, so these bugs are invalid now.