Follow-up of bug 1024298: zh-Pinyin should switch to half-width layout

RESOLVED INVALID

Status

Firefox OS
Gaia::Keyboard
RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: mnjul, Assigned: mnjul)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

This bug will do the issue 3 in the tracking bug 1054145:

When we are at type="number" input, Pinyin would be launched into full-width symbol panel. It should launch into half-width panel, as specified by UX.
Created attachment 8474374 [details] [review]
Patch (PR @ GitHub)

Let's have the bug tested!
Assignee: nobody → jlu
Summary: [Tracking] Follow-up of bug 1024298: zh-Pinyin should switch to half-width layout → Follow-up of bug 1024298: zh-Pinyin should switch to half-width layout
Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

Rudy, could you review this patch? Thanks!
Attachment #8474374 - Flags: review?(rlu)
Hi Omega,

I'd like to double confirm that the bug is valid -- it is desired that you want zh-Pinyin to be launched into *half-width* symbol panel for type="number" inputs, right?

I'm asking because for normal type="text" inputs, we launch into zh-Pinyin's alphabet panel and when user switches to symbol panel, it is the *full-width* symbol panel that is first presented. So I want to make sure such inconsistency is okay w.r.t. the type="number" spec.

Thanks a lot!
NI Omega for comment 3.
Flags: needinfo?(ofeng)
Hi John, right, it should go to half-width symbol 1 directly in a number input.
Also, Zhuyin should follow this rule. (Zhuyin is now being improved in bug 1019472, but not including the rule you mentioned.)
Flags: needinfo?(ofeng)
Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

John, Omega, 

Thanks for the confirmation.

In order to make Zhuyin also follow the same behavior, could we generalize this into a property in layout definition file? e.g.
defaultPageforNumber: 'zh-Hans-Pinyin-Symbol-En-1'.

I'll clear the review first.
Attachment #8474374 - Flags: review?(rlu)
Created attachment 8475786 [details] [diff] [review]
Diff between comment 2 and comment 8
Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

Hi Rudy,

Could you check the patch again? A diff from last revision is available at attachment 8475786 [details] [diff] [review]. Thanks!
Attachment #8474374 - Flags: review?(rlu)
Comment on attachment 8474374 [details] [review]
Patch (PR @ GitHub)

John, this looks pretty good to me.
Thank you.
Attachment #8474374 - Flags: review?(rlu) → review+
bug 1024298 got reverted and wontfix'ed, so these bugs are invalid now.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.