1054912 - Change 'Cast to' term to 'Send to ' in-product

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Karen Rudnitski [:kar]]

As discussed over email, Fx 33 will have the 'Cast to ' terminology, but this should be changed to 'Send to ' for Fx 34

Comment 1

[Karen Rudnitski [:kar]]

Sorry for the spam, but I meant to file this after Arcadio's final input and discussion with Matej. Adding Arcadio to comment.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: casting-strings v0.1

WIP

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

FYI, I changed "Cast to Device" to "Send to Device" and "Cast to Screen" to "Send to Device"

Comment 4

[Matej Novak [:matej]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> FYI, I changed "Cast to Device" to "Send to Device" and "Cast to Screen" to
> "Send to Device"

Are those purposely both "device" now? Should the second one still be "screen"?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Matej Novak [:matej] from comment #4)
> (In reply to Mark Finkle (:mfinkle) from comment #3)
> > FYI, I changed "Cast to Device" to "Send to Device" and "Cast to Screen" to
> > "Send to Device"
> 
> Are those purposely both "device" now? Should the second one still be
> "screen"?

No. For some reason I diverged the strings very early and never took the time to fix them. I think Google originally used "Screen" but moved to "Device". I am happy with "Device" used everywhere.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8474798 [details] [diff] [review]
casting-strings v0.1

I guess we need this landed soon to get in Fx34

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8474798 [details] [diff] [review]
casting-strings v0.1

Review of attachment 8474798 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/CastingApps.js
@@ +428,5 @@
>      // 2. The video is allowed to be cast and is currently playing
>      // Both states have the same action: Show the cast page action
>      if (aVideo.mozIsCasting) {
>        this.pageAction.id = PageActions.add({
> +        title: Strings.browser.GetStringFromName("contextmenu.sendToDevice"),

Hmm.. This string is actually kinda wrong. i.e. Shouldn't it read "Stop sending to device" or something?

@@ +435,5 @@
>          important: true
>        });
>      } else if (aVideo.mozAllowCasting) {
>        this.pageAction.id = PageActions.add({
> +        title: Strings.browser.GetStringFromName("contextmenu.sendToDevice"),

Are you ok with page actions reusing the context menu string? I think I can live with it. Maybe worth a note for localizers or a rename to "menu.sendToDevice"

::: mobile/android/locales/en-US/chrome/browser.properties
@@ +206,5 @@
>  # Text Selection
>  selectionHelper.textCopied=Text copied to clipboard
>  
>  # Casting
> +casting.sendToDevice=Send to Device

This key is a little less descriptive for localizers about where it will appear.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #7)
> Comment on attachment 8474798 [details] [diff] [review]

> ::: mobile/android/chrome/content/CastingApps.js

> >        this.pageAction.id = PageActions.add({
> > +        title: Strings.browser.GetStringFromName("contextmenu.sendToDevice"),
> 
> Hmm.. This string is actually kinda wrong. i.e. Shouldn't it read "Stop
> sending to device" or something?

No. The code will open the casting prompt again, allowing you to send the video to a different device. If we wanted to add a "This Device" to the list, like some Google Chromecast enabled apps do, we could add that to a new bug.

> @@ +435,5 @@
> >          important: true
> >        });
> >      } else if (aVideo.mozAllowCasting) {
> >        this.pageAction.id = PageActions.add({
> > +        title: Strings.browser.GetStringFromName("contextmenu.sendToDevice"),
> 
> Are you ok with page actions reusing the context menu string? I think I can
> live with it. Maybe worth a note for localizers or a rename to
> "menu.sendToDevice"

I'm fine with it until we decide to change the string

> ::: mobile/android/locales/en-US/chrome/browser.properties

> >  # Casting
> > +casting.sendToDevice=Send to Device
> 
> This key is a little less descriptive for localizers about where it will
> appear.

I can add a localization note

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: casting-strings v0.2

This adds the localization comments and also adds a "contentDescription" (and related changes) in the Java side.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Heads up to L10N that this patch will likely be landing in Aurora very soon after the merge. We'll try to get the patch landed ASAP. PR blog posts are going out referencing the new strings so it's important to get this into Fx34.

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 8481356 [details] [diff] [review]
casting-strings v0.2

Review of attachment 8481356 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/locales/en-US/chrome/browser.properties
@@ +387,5 @@
>  # LOCALIZATION NOTE (nativeWindow.deprecated):
>  # This string is shown in the console when someone uses deprecated NativeWindow apis.
>  # %1$S=name of the api that's deprecated, %2$S=New API to use. This may be a url to
>  # a file they should import or the name of an api.
> +nativeWindow.deprecated=%S is deprecated. Please use %S instead

See bug 1054177

Comment 12

[Francesco Lodolo [:flod]]

Side note: I've never seen late-l10n used on Gecko, at least on the rapid release cycle, not sure how helpful it is.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/e53a41405553

I am also pushing to aurora because we need the strings ASAP

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Francesco Lodolo [:flod] (offline from Aug 31 to Sep 7) from comment #11)

> ::: mobile/android/locales/en-US/chrome/browser.properties
> @@ +387,5 @@
> >  # LOCALIZATION NOTE (nativeWindow.deprecated):
> >  # This string is shown in the console when someone uses deprecated NativeWindow apis.
> >  # %1$S=name of the api that's deprecated, %2$S=New API to use. This may be a url to
> >  # a file they should import or the name of an api.
> > +nativeWindow.deprecated=%S is deprecated. Please use %S instead
> 
> See bug 1054177

Right. I didn't change the line, just added a newline at end of file (or my editor did)

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/e279f845b3d4

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e53a41405553

Comment 16

[Flaviu Cos]

Verified as fixed in build 34.0a2 (2014-09-05);
Device: Google Nexus 7 (Android 4.4.4).

Comment 17

[Flaviu Cos]

Verified as fixed in build 35.0a1 (2014-09-05);
Device: Google Nexus 7 (Android 4.4.4).