Closed Bug 1054989 Opened 6 years ago Closed 6 years ago

[Messages][DSDS] Send button refresh

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.2+)

RESOLVED FIXED
2.1 S5 (26sep)
feature-b2g 2.2+

People

(Reporter: julienw, Assigned: julienw)

References

Details

(Whiteboard: [p=1])

Attachments

(5 files, 2 obsolete files)

See attachment 8465221 [details] for the design spec.

This bug is _only_ about the send button. We'll change the SIM information style in the thread redesign in bug 1041765, in the same time we'll redesign the timestamp style (since it's the same style).
Due for v2.2 but attaching to the v2.1 in the absence of a specific bug for v2.2.
Attached file github PR
Attached image send button is disabled (obsolete) —
Attachment #8474528 - Flags: ui-review?(fshih)
Attached image send button is enabled (obsolete) —
Attachment #8474529 - Flags: ui-review?(fshih)
Hey Fang,

here are 2 screenshots, can you please tell me if it looks fine? Please look only to the send button (note that it looks also fuzzy because I didn't flash using the 1.5x assets, sorry for this).

Changes from current master:
* the SIM information is on the bottom, and slightly bigger (1.4rem now, was 1.3rem)
* the "..." mark is slightly below (2px below)

What I'm not sure:
* the "..." mark seems too big compared to your spec
* I'm not sure of the location of the various elements

Can you please precise this?

You can also install the WIP patch that I attached to the bug as well.

Thanks !
Flags: needinfo?(fshih)
Blocks: 1041765
Attached file SMS_DSDS_assets.zip
Attached the correct asset of the send button.
Flags: needinfo?(fshih)
Fang, sorry, we use real characters here, instead of an image.
Can you just explicit the font size and position?
Flags: needinfo?(fshih)
Comment on attachment 8474529 [details]
send button is enabled

I think the send button is bigger than the spec, so I've uploaded the new send button assets. After the send button change to the correct one, the edge of the send icon should be able to line up with the "1". The SIM menu dot, looks fine to me. Thank!
Attachment #8474529 - Flags: ui-review?(fshih) → ui-review-
Attachment #8474528 - Flags: ui-review?(fshih) → ui-review+
Flags: needinfo?(fshih)
(In reply to Julien Wajsberg [:julienw] (PTO 08/20 -> 09/15; contact schung instead) from comment #7)
> Fang, sorry, we use real characters here, instead of an image.
> Can you just explicit the font size and position?

Julien, do you meant the SIM dots?
yes, the small dots :) Sorry for not being precise enough.
Flags: needinfo?(fshih)
Attached image SIM_dot.png
Np, I attached the ... spec. Hope it works for you! Thanks!
Flags: needinfo?(fshih)
Should be fine, thanks !
QA Whiteboard: [COM=Gaia::SMS]
Nominating for 2.2
feature-b2g: --- → 2.2?
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S5 (26sep)
Assignee: nobody → felash
Status: NEW → ASSIGNED
Hey Fang, I can see that the new images are a lot bigger, and I can't see the reason. Can you please have a look? You can file the old one in [1]

[1] https://github.com/mozilla-b2g/gaia/tree/master/apps/sms/style/images/icons


Here are the size changes:

 apps/sms/style/images/icons/actionicon_sms_send_30x30.png       | Bin 343 -> 1292 bytes
 apps/sms/style/images/icons/actionicon_sms_send_30x30@1.5x.png  | Bin 484 -> 1491 bytes
 apps/sms/style/images/icons/actionicon_sms_send_30x30@2.25x.png | Bin 710 -> 1783 bytes
 apps/sms/style/images/icons/actionicon_sms_send_30x30@2x.png    | Bin 633 -> 1662 bytes
Flags: needinfo?(fshih)
Attached image screenshots for review
Hey Fang,

here are the new screenshots for your UI review. Can you please have a look?

The "..." has a font-size of 1.6rem because 1.7rem looks too big in my opinion, compared to the spec, but tell me what you think.
Attachment #8474528 - Attachment is obsolete: true
Attachment #8474529 - Attachment is obsolete: true
Attachment #8491609 - Flags: ui-review?(fshih)
Attached file Send_icons.zip
Hi Julien, 
Thanks for letting me know. I just compressed the icons to lower size, it should be smaller now! Thanks! :)
Flags: needinfo?(fshih)
Comment on attachment 8491609 [details]
screenshots for review

It looks good to me! Do you think I can also get a patch of this update, so I can try on my flame device? Thanks!
Attachment #8491609 - Flags: ui-review?(fshih) → ui-review+
Fang, the pull request at https://github.com/mozilla-b2g/gaia/pull/22992 is uptodate if you want to test yourself :) (it does not have the new images from this morning yet, though)
Comment on attachment 8474526 [details] [review]
github PR

Oleg, Fang, here is the uptodate pull request.

Fang, maybe the button is a little too much to the left in single SIM mode, can you have a look? Maybe that's me :)

Please tell me what you think :)
Attachment #8474526 - Flags: ui-review?(fshih)
Attachment #8474526 - Flags: review?(azasypkin)
Comment on attachment 8474526 [details] [review]
github PR

Code-wise patch looks good to me. Let's wait for ui-review!

Thanks!
Attachment #8474526 - Flags: review?(azasypkin) → review+
Comment on attachment 8474526 [details] [review]
github PR

Hi Julien,

Thanks for mentioning, I was thinking about that as well. Maybe Could you move  it to right by 2 px. Thanks! : )
Attachment #8474526 - Flags: ui-review?(fshih) → ui-review+
Updated the pull request to move the button to the right by 2px. Got a sign-in from Oleg on IRC :)

I don't have my phone here so I'll check later and then land at last :)
master: 9fb6c954d2143a21f79e8eae36ea531067802735
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
let's keep the already-landed improvement in 2.2.
feature-b2g: 2.2? → 2.2+
You need to log in before you can comment on or make changes to this bug.