allow for talos preferences to have variables

RESOLVED FIXED in mozilla34

Status

Testing
Talos
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Assigned: Mardak)

Tracking

Trunk
mozilla34
Points:
3
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
talos has variables like ${talos} and ${firefox} that are used in the config.  During setup we substitute those placeholders for real values.  This allows us to work in production/development as well as other environments with less pain.

There is a need to do this for the preferences that we have.  Specifically in this case the webserver.  We should be able to set a preferences to http://localhost/..../myresource.vba and access all the goodness of a .vba file :)

Once we have this in place we can fix up a few other instances of manual webserver value replacement (mostly for media tests and android remote bits)

Here are some pointers of things to do:
https://bugzilla.mozilla.org/show_bug.cgi?id=1054202#c18
(Assignee)

Comment 1

3 years ago
I got talos built and running locally now, so I'll take a stab at this.
(Assignee)

Comment 2

3 years ago
Created attachment 8477230 [details] [diff] [review]
v1
Attachment #8477230 - Flags: review?(jmaher)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8477230 [details] [diff] [review]
v1

Review of attachment 8477230 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great.  I like the scheme detection as well!
Attachment #8477230 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

3 years ago
http://hg.mozilla.org/build/talos/rev/71cb14ebe07e
Assignee: nobody → edilee
Iteration: --- → 34.3
Points: --- → 3
Flags: firefox-backlog+
Target Milestone: --- → mozilla34
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.