Closed Bug 1055012 Opened 5 years ago Closed 5 years ago

crash in java.lang.IllegalStateException: Not connected. Call connect() and wait for onConnected() to be called. at com.google.android.gms.internal.hc.ci(Unknown Source)

Categories

(Firefox for Android :: Screencasting, defect, critical)

All
Android
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox33 --- verified
firefox34 --- verified
firefox35 --- verified
fennec 33+ ---

People

(Reporter: cos_flaviu, Assigned: wesj)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-21cabcfa-feb7-40e2-a986-b70252140818.
=============================================================

Environment: 
Device: Asus Transformer Tab (Android 4.2.1);
Build: Nightly 34.0a1 (2014-08-18);

Steps to reproduce:
1. Go to http://people.mozilla.org/~mfinkle/casting/test.html
2. Tap on the video area to play the video;
3. Tap the cast icon located on URL bar;
4. Tap on Chromecast device from the contextmenu.

Expected result:
The video starts to play on Chromecast device.

Actual result:
Firefox crashes.

Notes:
Only reproducible when casting from the icon from the URL bar.
Blocks: 921924
tracking-fennec: --- → ?
Assignee: nobody → wjohnston
tracking-fennec: ? → 33+
Attached patch PatchSplinter Review
Is this still reproducible? AFAICT, the object that's throwing is created inside the onConnected call itself, which even has a isConnected check inside it. But the callback could be called later, so maybe we lose the connection between the two?

I hate sprinkling these checks all over... trying to think of something better, but a bit hard to do with hard to reproduce crashes. We probably get a can turn on some extra logging in here so that we have some better clues about what is happening?
Attachment #8478383 - Flags: review?(mark.finkle)
Attachment #8478383 - Flags: review?(mark.finkle) → review+
Comment on attachment 8478383 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: chromecast
[User impact if declined]: possible crashes? I haven't been able to reproduce this, so its a speculative fix.
[Describe test coverage new/current, TBPL]: working on it.
[Risks and why]: low risk safety check. hard to verify though. A guess based on logs
[String/UUID change made/needed]: none.
Attachment #8478383 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/8591ca11b950
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8478383 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in builds:
- 35.0a1 (2014-09-05);
- 34.0a2 (2014-09-05);
Device: Asus Transformer Tab (Android 4.2.1);
Verified as fixed in build 33 beta 1;
Device: Asus Transformer Tab (Android 4.2.1);
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.