105504 - Bugzilla LDAP does not close connection (CGI::confirm_login())

Status: RESOLVED INVALID

(Bugzilla :: Administration, task, P3)

Description

[James A. Laska]

CGI:confirm_login() is not properly implemented to handle LDAP logins.  There
are several issues (not sure whether they are ascthetic or not):

1) LDAP connection is never closed
2) LDAP does not properly make use of Param("LDAPmailattribute") when searching
for email address matches.
3) LDAP user bind closes/reconnects when a simpleAuth() call would achieve the
desired user bind

I am attaching a rough patch that I unfortunately had to hand edit to remove
unrelated changes and messages.

Comment 1

[James A. Laska]

Attachment: CGI::confirm_login() - LDAP login fixes

Comment 2

[Dave Miller [:justdave]]

adding CCs of people who know something about LDAP

Comment 3

[James A. Laska]

The simpleAuth portion of this patch should be changed to:

        # Now we attempt to bind as the specified user.
       my $retcode = $LDAPconn->simpleAuth($userDN,$::FORM{"LDAP_password"});
       if ( ($::FORM{"LDAP_password"} eq "") ||
           ($userDN eq "") ||
           ($retcode == 0)  )
       {
            ... error ....
       }

Oops...

Comment 4

[Carl Makin]

The original patch sorta works in 2.16RC2.  It fixes the open/close/open
problem, but it replaces "uid=" with Param("LDAPmailattribuet") on the query
which doesn't work.

I'll upload the patch we are using as an attachment.

Comment 5

[Carl Makin]

Attachment: Newer patch to 2.16RC2 to fix open/close/open problem.

Comment 6

[Bradley Baetz (:bbaetz)]

Comment on attachment 90264 [details] [diff] [review]
Newer patch to 2.16RC2 to fix open/close/open problem.

This patch is reversed, and it needs to be a diff -u, as well. It looks good,
though.

Comment 7

[Bradley Baetz (:bbaetz)]

Isn't this implicitly closed when the scalar ref goes out of scope?

This has all moved to Net::LDAP + Bugzilla/Auth/LDAP.pm in CVS - is this bug
still valid?

Comment 8

[Joel Peshkin]

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.

Comment 9

[Max Kanat-Alexander]

No response to comment 7, assuming that bug is now INVALID after the re-write.

Comment 10

[Dave Miller [:justdave]]

clearing target of DUPLICATE/WONTFIX/INVALID/WORKSFORME so they'll show up as
untriaged if they get reopened.