Closed Bug 1055078 Opened 11 years ago Closed 5 years ago

Review MDN JavaScript with JSHint

Categories

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Product:
developer.mozilla.org Graveyard
Component:
Code Cleanup
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: davidwalsh, Unassigned)

Details

(Whiteboard: [specification][type:bug][dev-papercut])

What did you do? ================ Now would be a good time to review the JavaScript on MDN and update any JSHint notifications. I believe this will tighten our front-end coding practices. What happened? ============== Nothing is broken or malfunctioning at the moment -- just setting a standard. What should have happened? ========================== N/A Is there anything else we should know? ====================================== I'll talk to the team and make sure we institute this practice throughout.
Severity: normal → minor
Whiteboard: [specification][type:bug] → [specification][type:bug][dev-papercut]
Component: General → Code Cleanup
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/21cac36c31027b65074a758f945800b57249f1be bug 1055078 - Add JSHint to dev machines https://github.com/mozilla/kuma/commit/cef467b56701d0b0c321ee55eacd0ca94c63285b bug 1055078 - Make analytics.js pass jshint https://github.com/mozilla/kuma/commit/87e11600e0bb7ace62b7d3ec5a8a81d8d1f88222 bug 1055078 - Make auth.js pass jshint https://github.com/mozilla/kuma/commit/cd251f84e5b54243965115da31dcdb3c45b23d95 bug 1055078 - Make badges.js pass jshint https://github.com/mozilla/kuma/commit/795b8b3727475504f8a92ce295edd2f387ccdaeb bug 1055078 - Make components.js pass jshint https://github.com/mozilla/kuma/commit/9956915be8416a0478c816871bfe029a11245bf7 bug 1055078 - Make main.js pass jshint https://github.com/mozilla/kuma/commit/8612d3ada1e221eb76f89edd5e731585d73a790f bug 1055078 - Make promote.js pass jshint https://github.com/mozilla/kuma/commit/757f70ec1543dc20ccbf7f780ecf6386e7a9c3e7 bug 1055078 - Make search-navigator.js pass jshint https://github.com/mozilla/kuma/commit/5d92bc50be2b6c812c170c1962a64672e77d7294 bug 1055078 - Make wiki.js pass jshint https://github.com/mozilla/kuma/commit/cc78dadb0ea3c9be9c4dfd46cda48fc057311e10 bug 1055078 - Move selectivizr to allow jshint'ing on entire directory https://github.com/mozilla/kuma/commit/42a74bed25f578a05da32a12b32cb92eadf6c430 bug 1055078 - Add acceptable globals to JSHint config https://github.com/mozilla/kuma/commit/f1f37bf2220db7c924f5b7dcbf97a2e597718044 bug 1055078 - Make syntax-prism.js pass jshint https://github.com/mozilla/kuma/commit/d3305a242a9e139b2dd0791a514b28174d8a31f2 bug 1055078 - Make moz-jquery-plugins.js pass jshint https://github.com/mozilla/kuma/commit/aad2653ba9b622c95031e43f0170662aafebc523 bug 1055078 - Make wiki-admin.js pass jshint https://github.com/mozilla/kuma/commit/a448f1d4fec0da95c97359cb3e5a201ee6f13623 bug 1055078 - Make wiki-tags-edit.js pass jshint https://github.com/mozilla/kuma/commit/77f81f830ccbe6f86ae682327c349fa82144fcc0 bug 1055078 - Resolve profile.js merge conflict https://github.com/mozilla/kuma/commit/be5cddc59118a2be3a0644169adb7310d2a745a5 Merge pull request #2800 from darkwing/jshint bug 1055078 - Add JSHint to dev machines
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/8d396a351e21d0109cbf3d5da52bd37b84f1dbfd bug 1055078 - Fellowship and auth cleanup https://github.com/mozilla/kuma/commit/2fc7893a61afe97e8b6206101319be534cfd765b Merge pull request #3427 from darkwing/js-cleanup-1055078 bug 1055078 - Fellowship and auth cleanup
MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.