Closed Bug 1055141 Opened 6 years ago Closed 6 years ago

convert AudioStream's mCubebStream member to a UniquePtr

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This is one of those cases where UniquePtr is not quite as nice as nsAutoRef,
because there's no implicit conversion to T*.  UniquePtr follows
std::unique_ptr in this decision.  Anyway, getting rid of nsAutoRef is a plus.
Attachment #8474665 - Flags: review?(cpearce)
Comment on attachment 8474665 [details] [diff] [review]
use a UniquePtr for AudioStream's mCubebStream member

Review of attachment 8474665 [details] [diff] [review]:
-----------------------------------------------------------------

This is more Matthew's area than mine.
Attachment #8474665 - Flags: review?(cpearce) → review?(kinetik)
Attachment #8474665 - Flags: review?(kinetik) → review+
Assignee: nobody → nfroyd
This landed: http://hg.mozilla.org/mozilla-central/rev/5650d84919fc

I guess mcMerge missed this.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.