1055178 - Dropdown in Toolbox Options isn't opened correctly

Status: RESOLVED DUPLICATE of bug 1098431

(DevTools :: General, defect)

Description

[obrufau]

Attachment: Screenshot

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140817030204

Steps to reproduce:

1. Open devtools
2. Go to Toolbox Options
3. Click a dropdown


Actual results:

The dropdown opens at a wrong position.


Expected results:

It should open at the right position.

Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ddcf4f4af7d9&tochange=c9562d81f40d

Comment 1

[obrufau]

Probably caused by bug 1050857, which changed options panel.

However, the root cause may be a problem displaying <menupopup>.

Comment 2

[obrufau]

I have just filed bug 1055702, which should fix this one.

Comment 4

[obrufau]

Since bug 1055702 hasn't been fixed, here is an alternative workaround.

In chrome://browser/content/devtools/framework/options-panel.css, instead of the current

> #options-panel {
>     display: block;
> }

we could use

> #options-panel {
>     display: flex;
>     flex-wrap: wrap;
> }

It seems it produces the same layout but without the dropdown problems.

Comment 5

[obrufau]

The code above doesn't produce the exact same layout in case the window is tall enough.

It needs some additional changes:

 - Remove `theme-body` class of `options-panel`
 - Add `theme-body` class to `options-panel-container`
 - Add `#options-panel-container { display: block; }`

Those changes only fix the dropdowns if the zoom is 100%. Otherwise, the problem is still there.

Comment 6

[Paul Rouget [:paul]]

(In reply to obrufau from comment #5)
Feel like taking this bug?

Comment 7

[obrufau]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #6)
> (In reply to obrufau from comment #5)
> Feel like taking this bug?

Ok. But I've never taken a bug, and I don't know how to submit patches and things like this. So I would appreciate some guidance.

Comment 8

[obrufau]

This has been fixed in bug 1098431.