The default bug view has changed. See this FAQ.

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: zeller)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 9 obsolete attachments)

(Reporter)

Description

3 years ago
John, you'll need something similar to this:
https://github.com/mozilla/build-puppet/tree/master/modules/releaserunner
https://github.com/mozilla/build-puppet/blob/master/modules/toplevel/manifests/mixin/releaserunner.pp
https://github.com/mozilla/build-puppet/blob/master/manifests/moco-nodes.pp#L461
https://github.com/mozilla/build-puppet/blob/master/modules/config/manifests/base.pp#L204
https://github.com/mozilla/build-puppet/blob/master/manifests/moco-config.pp#L151

A few things to watch out for:
* You probably don't need an SSH key for ship it notifier
* Try to avoid using a .sh wrapper script like release runner does.

I'm going to try to figure out how to get you enough access to test this.
(Assignee)

Comment 1

3 years ago
Created attachment 8474916 [details] [diff] [review]
bug1055191.patch

I filled out most of the necessary parts for puppet to launch shipit-notifier, but it's incomplete. Now that I have the parts existing I'd love some feedback on what's wrong, what's missing, etc.
Attachment #8474916 - Flags: feedback?(bhearsum)
(Assignee)

Comment 2

3 years ago
Created attachment 8474919 [details] [diff] [review]
bug1055191.patch

Small fix of a filename
Attachment #8474916 - Attachment is obsolete: true
Attachment #8474916 - Flags: feedback?(bhearsum)
Attachment #8474919 - Flags: feedback?(bhearsum)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8474919 [details] [diff] [review]
bug1055191.patch

Review of attachment 8474919 [details] [diff] [review]:
-----------------------------------------------------------------

This looks mostly fine, there's a few comments below. I'm still working to get you a machine you can test this on.

::: manifests/moco-config.pp
@@ +159,5 @@
>      $releaserunner_ssh_username = "cltbld"
>  
> +    $shipit_notifier_api_root = "http://ship-it.mozilla.org"
> +    $shipit_notifier_api_username = ""
> +    $shipit_notifier_api_password = ""

You should set username correctly here - it will be "ffxbld", just like release runner. The password will be set in hiera - I'll take care of that.

::: modules/shipit_notifier/manifests/init.pp
@@ +35,5 @@
> +                "requests==2.3.0",
> +                "simplejson==3.6.2",
> +                "six==1.7.3",
> +                "wsgiref==0.1.2",
> +                "zope.interface==4.1.1",

I don't think this is the right depedency list. Eg, I doubt you're using docopt, SQLAlchemy, or Pulse. Please trim this.
Attachment #8474919 - Flags: feedback?(bhearsum) → feedback+
(Reporter)

Comment 4

3 years ago
Comment on attachment 8474919 [details] [diff] [review]
bug1055191.patch

Review of attachment 8474919 [details] [diff] [review]:
-----------------------------------------------------------------

::: manifests/moco-config.pp
@@ +159,5 @@
>      $releaserunner_ssh_username = "cltbld"
>  
> +    $shipit_notifier_api_root = "http://ship-it.mozilla.org"
> +    $shipit_notifier_api_username = ""
> +    $shipit_notifier_api_password = ""

Whoops - username will be in Hiera too. So just drop these two lines from this.
(Assignee)

Comment 5

3 years ago
(In reply to Ben Hearsum [:bhearsum] from comment #4)
> Comment on attachment 8474919 [details] [diff] [review]
> bug1055191.patch
> 
> Review of attachment 8474919 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: manifests/moco-config.pp
> @@ +159,5 @@
> >      $releaserunner_ssh_username = "cltbld"
> >  
> > +    $shipit_notifier_api_root = "http://ship-it.mozilla.org"
> > +    $shipit_notifier_api_username = ""
> > +    $shipit_notifier_api_password = ""
> 
> Whoops - username will be in Hiera too. So just drop these two lines from
> this.

As in don't even include the lines with empty strings in moco-config.pp?
(Reporter)

Comment 6

3 years ago
(In reply to John Zeller [:zeller] from comment #5)
> (In reply to Ben Hearsum [:bhearsum] from comment #4)
> > Comment on attachment 8474919 [details] [diff] [review]
> > bug1055191.patch
> > 
> > Review of attachment 8474919 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: manifests/moco-config.pp
> > @@ +159,5 @@
> > >      $releaserunner_ssh_username = "cltbld"
> > >  
> > > +    $shipit_notifier_api_root = "http://ship-it.mozilla.org"
> > > +    $shipit_notifier_api_username = ""
> > > +    $shipit_notifier_api_password = ""
> > 
> > Whoops - username will be in Hiera too. So just drop these two lines from
> > this.
> 
> As in don't even include the lines with empty strings in moco-config.pp?

That's right - they are exclusively in Hiera - it would be confusing to define them here too.
(Assignee)

Comment 7

3 years ago
Created attachment 8475542 [details] [diff] [review]
bug1055191.patch

Okay I am stuck at ssh keys here. I tried not including an ssh key, and I got the following, where puppet attempts to download dependencies, but skips each because it doesn't have an ssh key. How do you suggest I get around this without ssh keys? Output: http://zeller.pastebin.mozilla.org/6059850

The patch I have attached includes all the changes I have made thus far, plus adding of ssh key into the config. Though since no ssh keys exist puppet obviously fails here. Output: http://zeller.pastebin.mozilla.org/6059888
Attachment #8474919 - Attachment is obsolete: true
Attachment #8475542 - Flags: feedback?(bhearsum)
(Reporter)

Comment 8

3 years ago
(In reply to John Zeller [:zeller] from comment #7)
> Created attachment 8475542 [details] [diff] [review]
> bug1055191.patch
> 
> Okay I am stuck at ssh keys here. I tried not including an ssh key, and I
> got the following, where puppet attempts to download dependencies, but skips
> each because it doesn't have an ssh key. How do you suggest I get around
> this without ssh keys? Output: http://zeller.pastebin.mozilla.org/6059850

This one is very confusing. I don't have a clue about it. Any ideas Dustin?

> The patch I have attached includes all the changes I have made thus far,
> plus adding of ssh key into the config. Though since no ssh keys exist
> puppet obviously fails here. Output:
> http://zeller.pastebin.mozilla.org/6059888

I don't think Ship It Notifier needs an SSH key, so you should probably drop any reference to that. Release runner needs one because it talks to other buildbot masters. Ship It Notifier only talks to Ship It, and that's done with a username and password.
Flags: needinfo?(dustin)
(Reporter)

Comment 9

3 years ago
Comment on attachment 8475542 [details] [diff] [review]
bug1055191.patch

Review of attachment 8475542 [details] [diff] [review]:
-----------------------------------------------------------------

This looks pretty reasonable. Need to deal with the ssh key thing per my previous comment, and more thing:

::: modules/shipit_notifier/manifests/init.pp
@@ +9,5 @@
> +    include shipit_notifier::services
> +    include packages::mozilla::python27
> +    include packages::gcc
> +    include packages::make
> +    include packages::mysql_devel

I don't think you need most of these packages. Probably just the python one.
Attachment #8475542 - Flags: feedback?(bhearsum) → feedback+
(Assignee)

Comment 10

3 years ago
Created attachment 8477013 [details] [diff] [review]
bug1055191.patch

Made all of the requested changes here and tested them with the test instances that bhearsum supplied. The output from most recent test is here: http://zeller.pastebin.mozilla.org/6087793

Not sure what the next step of testing is here, but I imagine it is using these puppet manifests to launch and use shipit-notifier to see that it works properly :)
Attachment #8475542 - Attachment is obsolete: true
Attachment #8477013 - Flags: review?(bhearsum)
(Reporter)

Comment 11

3 years ago
Comment on attachment 8477013 [details] [diff] [review]
bug1055191.patch

Review of attachment 8477013 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/config/manifests/base.pp
@@ +240,5 @@
> +    # mercurial repository and branch for tools
> +    $shipit_notifier_tools = "https://hg.mozilla.org/build/tools"
> +    $shipit_notifier_tools_branch = "default"
> +    # root directory for shipit_notifier; this must be under /builds
> +    $shipit_notifier_root = "/builds/shipit_notifer"

notifer? Looks like a typo to me...

::: modules/shipit_notifier/manifests/services.pp
@@ +7,5 @@
> +    include shipit_notifier::settings
> +
> +    supervisord::supervise {
> +        "shipit_notifier":
> +            command      => "${shipit_notifier::settings::tools_dst}/buildfarm/release/shipit-notifier.py -c ${shipit_notifier::settings::root}/shipit_notifier.ini",

I managed to puppetize a system with this just fine, but shipit notifier wouldn't start -- it was complaining that it couldn't find the "pytz" module. I think this is because you're running shipit_notifier.py directly, which uses the system python. You need to make sure it gets run with the python from the virtualenv.

You should be able to test this yourself by running "service supervisord restart" after running Puppet. Supervisord has general logs in /var/log/supervisord, and the shipit-notifier one will end up in /builds/shipit_notifier.
Attachment #8477013 - Flags: review?(bhearsum) → review-
(Assignee)

Comment 12

3 years ago
(In reply to Ben Hearsum [:bhearsum] from comment #11)
> Comment on attachment 8477013 [details] [diff] [review]
> bug1055191.patch
> 
> Review of attachment 8477013 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/shipit_notifier/manifests/services.pp
> @@ +7,5 @@
> > +    include shipit_notifier::settings
> > +
> > +    supervisord::supervise {
> > +        "shipit_notifier":
> > +            command      => "${shipit_notifier::settings::tools_dst}/buildfarm/release/shipit-notifier.py -c ${shipit_notifier::settings::root}/shipit_notifier.ini",
> 
> I managed to puppetize a system with this just fine, but shipit notifier
> wouldn't start -- it was complaining that it couldn't find the "pytz"
> module. I think this is because you're running shipit_notifier.py directly,
> which uses the system python. You need to make sure it gets run with the
> python from the virtualenv.
> 
> You should be able to test this yourself by running "service supervisord
> restart" after running Puppet. Supervisord has general logs in
> /var/log/supervisord, and the shipit-notifier one will end up in
> /builds/shipit_notifier.

I've been trying to replicate this and am having trouble. I tried running 'service supervisord restart' after running 'puppet agent --server releng-puppet2.srv.releng.scl3.mozilla.com --environment=jozeller' on root@zeller-buildbot-master.bb.releng.use1.mozilla.com and it seems to have no effect in relation to shipit-notifier. This was the output: http://zeller.pastebin.mozilla.org/6298094 

Any thoughts on how to proceed? Also there were no log files present for supervisord or shipit_notifier.
Flags: needinfo?(bhearsum)
(Reporter)

Comment 13

3 years ago
(In reply to John Zeller [:zeller] from comment #12)
> (In reply to Ben Hearsum [:bhearsum] from comment #11)
> > Comment on attachment 8477013 [details] [diff] [review]
> > bug1055191.patch
> > 
> > Review of attachment 8477013 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: modules/shipit_notifier/manifests/services.pp
> > @@ +7,5 @@
> > > +    include shipit_notifier::settings
> > > +
> > > +    supervisord::supervise {
> > > +        "shipit_notifier":
> > > +            command      => "${shipit_notifier::settings::tools_dst}/buildfarm/release/shipit-notifier.py -c ${shipit_notifier::settings::root}/shipit_notifier.ini",
> > 
> > I managed to puppetize a system with this just fine, but shipit notifier
> > wouldn't start -- it was complaining that it couldn't find the "pytz"
> > module. I think this is because you're running shipit_notifier.py directly,
> > which uses the system python. You need to make sure it gets run with the
> > python from the virtualenv.
> > 
> > You should be able to test this yourself by running "service supervisord
> > restart" after running Puppet. Supervisord has general logs in
> > /var/log/supervisord, and the shipit-notifier one will end up in
> > /builds/shipit_notifier.
> 
> I've been trying to replicate this and am having trouble. I tried running
> 'service supervisord restart' after running 'puppet agent --server
> releng-puppet2.srv.releng.scl3.mozilla.com --environment=jozeller' on
> root@zeller-buildbot-master.bb.releng.use1.mozilla.com and it seems to have
> no effect in relation to shipit-notifier. This was the output:
> http://zeller.pastebin.mozilla.org/6298094 
> 
> Any thoughts on how to proceed? Also there were no log files present for
> supervisord or shipit_notifier.

Supervisord appears to have errors in its log:
-bash-4.1# pwd
/var/log/supervisor
-bash-4.1# cat supervisord.log-20140904
2014-09-03 13:25:34,930 CRIT Supervisor running as root (no user in config file)
2014-09-03 13:25:34,930 WARN Included extra file "/etc/supervisord.d/shipit_notifier" during parsing
2014-09-03 13:25:34,994 INFO RPC interface 'supervisor' initialized
2014-09-03 13:25:34,994 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2014-09-03 13:25:35,000 INFO daemonizing the supervisord process
2014-09-03 13:25:35,001 INFO supervisord started with pid 6367
2014-09-03 13:25:36,003 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:25:37,005 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:25:39,018 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:25:42,022 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:25:42,024 INFO gave up: shipit_notifier entered FATAL state, too many start retries too quickly
2014-09-03 13:27:59,749 WARN received SIGTERM indicating exit request
2014-09-03 13:28:00,059 CRIT Supervisor running as root (no user in config file)
2014-09-03 13:28:00,059 WARN Included extra file "/etc/supervisord.d/shipit_notifier" during parsing
2014-09-03 13:28:00,122 INFO RPC interface 'supervisor' initialized
2014-09-03 13:28:00,122 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2014-09-03 13:28:00,128 INFO daemonizing the supervisord process
2014-09-03 13:28:00,139 INFO supervisord started with pid 6387
2014-09-03 13:28:01,141 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:28:02,143 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:28:04,146 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:28:07,150 INFO spawnerr: can't find command '/builds/shipit_notifer/tools/buildfarm/release/shipit-notifier.py'
2014-09-03 13:28:07,150 INFO gave up: shipit_notifier entered FATAL state, too many start retries too quickly

I suspect the main issue here is that the code isn't in the tools repo right now. But also, please note that it's still looking in the wrong directory ("shipit_notifer"). Until the code gets relanded, I suggest locally patching the tools repo after its deployed.
Flags: needinfo?(bhearsum)
(Reporter)

Comment 14

3 years ago
I relanded the patch from bug 1032978 today, so you probably don't need to locally patch the tools repo anymore.
(Reporter)

Updated

3 years ago
Flags: needinfo?(dustin)
(Assignee)

Comment 15

3 years ago
Created attachment 8488897 [details] [diff] [review]
bug1055191.patch

Got things to the point that --test is not complaining. A couple of things to remember, that set me back a bit were:

* ln -s manifests/moco-config.pp config.pp
* ln -s manifests/moco-nodes.pp nodes.pp

Other than that, When I first apply the new patch to a fresh puppet clone, I get a message that there is a missing '}' in manifests/servo-config.pp. Upon investigating, it looks like indeed, line 56 had a premature '}'. Any idea why this is? I removed it from my instance, and things ran okay. Here is the copy of the original, before deleting the extra '}' on line 56: http://zeller.pastebin.mozilla.org/6457875

My current roadblock is when running 'puppet agent -v --server releng-puppet2.srv.releng.scl3.mozilla.com --environment=jozeller' I get:
Error: Could not run: Could not create PID file: /var/run/puppet/agent.pid

Any clue how to proceed here?

If I run 'service supervisord restart' anyway, then the log at /var/log/supervisor/supervisord.log shows:
2014-09-12 19:27:45,604 WARN received SIGTERM indicating exit request
2014-09-12 19:27:45,912 CRIT Supervisor running as root (no user in config file)
2014-09-12 19:27:45,912 WARN Included extra file "/etc/supervisord.d/shipit_notifier" during parsing
2014-09-12 19:27:45,974 INFO RPC interface 'supervisor' initialized
2014-09-12 19:27:45,974 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2014-09-12 19:27:45,979 INFO daemonizing the supervisord process
2014-09-12 19:27:45,980 INFO supervisord started with pid 23362
2014-09-12 19:27:46,982 INFO spawnerr: command at '/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py' is not executable
2014-09-12 19:27:47,984 INFO spawnerr: command at '/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py' is not executable
2014-09-12 19:27:49,987 INFO spawnerr: command at '/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py' is not executable
Attachment #8477013 - Attachment is obsolete: true
It sounds like you're not running puppet as root.  Puppet has to be run as root.

As for the stray }, I assume that's in your patch, as there's no } on line 56 in the repo.
(Assignee)

Comment 17

3 years ago
(In reply to Dustin J. Mitchell [:dustin] from comment #16)
> It sounds like you're not running puppet as root.  Puppet has to be run as
> root.
> 
> As for the stray }, I assume that's in your patch, as there's no } on line
> 56 in the repo.

I checked and it's run as root :/
(Assignee)

Comment 18

3 years ago
comment 15
Flags: needinfo?(bhearsum)
(Reporter)

Comment 19

3 years ago
(In reply to John Zeller [:zeller] from comment #15)
> Created attachment 8488897 [details] [diff] [review]
> bug1055191.patch
> 
> Got things to the point that --test is not complaining. A couple of things
> to remember, that set me back a bit were:
> 
> * ln -s manifests/moco-config.pp config.pp
> * ln -s manifests/moco-nodes.pp nodes.pp
> 
> Other than that, When I first apply the new patch to a fresh puppet clone, I
> get a message that there is a missing '}' in manifests/servo-config.pp. Upon
> investigating, it looks like indeed, line 56 had a premature '}'. Any idea
> why this is? I removed it from my instance, and things ran okay. Here is the
> copy of the original, before deleting the extra '}' on line 56:
> http://zeller.pastebin.mozilla.org/6457875

This is very confusing, I'm not sure why servo-config.pp would be parsed at all.

> My current roadblock is when running 'puppet agent -v --server
> releng-puppet2.srv.releng.scl3.mozilla.com --environment=jozeller' I get:
> Error: Could not run: Could not create PID file: /var/run/puppet/agent.pid

Ping me later today and I'll try to help work through this.

> Any clue how to proceed here?
> 
> If I run 'service supervisord restart' anyway, then the log at
> /var/log/supervisor/supervisord.log shows:
> 2014-09-12 19:27:45,604 WARN received SIGTERM indicating exit request
> 2014-09-12 19:27:45,912 CRIT Supervisor running as root (no user in config
> file)
> 2014-09-12 19:27:45,912 WARN Included extra file
> "/etc/supervisord.d/shipit_notifier" during parsing
> 2014-09-12 19:27:45,974 INFO RPC interface 'supervisor' initialized
> 2014-09-12 19:27:45,974 CRIT Server 'unix_http_server' running without any
> HTTP authentication checking
> 2014-09-12 19:27:45,979 INFO daemonizing the supervisord process
> 2014-09-12 19:27:45,980 INFO supervisord started with pid 23362
> 2014-09-12 19:27:46,982 INFO spawnerr: command at
> '/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py' is not
> executable
> 2014-09-12 19:27:47,984 INFO spawnerr: command at
> '/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py' is not
> executable
> 2014-09-12 19:27:49,987 INFO spawnerr: command at
> '/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py' is not
> executable

This probably isn't relevant until you've puppetized with your latest manifests.
Flags: needinfo?(bhearsum)
I missed the filename -- I'll fix that trailing } in servo-config.pp now.
(Assignee)

Comment 21

3 years ago
Created attachment 8490477 [details] [diff] [review]
bug1055191.patch
Attachment #8488897 - Attachment is obsolete: true
(Assignee)

Comment 22

3 years ago
Created attachment 8490505 [details] [diff] [review]
tools-bug1055191.patch

Possible change to tools
(Assignee)

Comment 23

3 years ago
Created attachment 8490506 [details] [diff] [review]
bug1055191.patch

Okay so this patch is just about ready as far as I can tell. The only remaining issue seems to be the /tools change, which I added above. This worked when I made the changes manually while testing, and shipit_notifier even started! But when I removed /builds/shipit_notifier, let puppet agent rerun everything, and then applied the above patch to /tools, I ran into the following error again:

Traceback (most recent call last):
  File "/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py", line 17, in <module>
    from kickoff.api import Status
ImportError: cannot import name Status


Gonna look at this again in the morning. Any ideas?
Attachment #8490477 - Attachment is obsolete: true
Attachment #8490506 - Flags: feedback?(bhearsum)
Flags: needinfo?(bhearsum)
(Reporter)

Comment 24

3 years ago
(In reply to John Zeller [:zeller] from comment #23)
> Created attachment 8490506 [details] [diff] [review]
> bug1055191.patch
> 
> Okay so this patch is just about ready as far as I can tell. The only
> remaining issue seems to be the /tools change, which I added above. This
> worked when I made the changes manually while testing, and shipit_notifier
> even started! But when I removed /builds/shipit_notifier, let puppet agent
> rerun everything, and then applied the above patch to /tools, I ran into the
> following error again:
> 
> Traceback (most recent call last):
>   File "/builds/shipit_notifier/tools/buildfarm/release/shipit-notifier.py",
> line 17, in <module>
>     from kickoff.api import Status
> ImportError: cannot import name Status
> 
> 
> Gonna look at this again in the morning. Any ideas?

I still see this import prior to addsitedir (in addition to after it):
from kickoff.api import Status
from os import path
from dateutil import parser

import sys
sys.path.insert(0, path.join(path.dirname(__file__), "../../lib/python"))
from kickoff.api import Status
Flags: needinfo?(bhearsum)
(Reporter)

Comment 25

3 years ago
Comment on attachment 8490506 [details] [diff] [review]
bug1055191.patch

Review of attachment 8490506 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on this, but please coordinate with me to land it - I need to make sure I'll be available to deal with any potential fallout.

::: manifests/moco-nodes.pp
@@ +472,5 @@
>  }
>  
> +node "zeller-buildbot-master.bb.releng.use1.mozilla.com" {
> +    include toplevel::mixin::shipit_notifier
> +}

This shouldn't be included, please remove it when you land.
Attachment #8490506 - Flags: feedback?(bhearsum) → review+
(Assignee)

Comment 26

3 years ago
Created attachment 8490895 [details] [diff] [review]
tools-bug1055191.patch

Bah, removed the Status line. Dumb thing to miss, ha :)
Attachment #8490505 - Attachment is obsolete: true
Attachment #8490895 - Flags: review?(bhearsum)
(Assignee)

Comment 27

3 years ago
Created attachment 8490896 [details] [diff] [review]
puppet manifests for deploying ship it notifier

Removed dev host. This seems to work fine!

Gonna post another patch here though for shipit-notifier.py, it is exiting with 1 for a timeout error. Might be a problem only with the server I am developing on. However, supervisord is restarting it successfully each time, which is good news :)
Attachment #8490506 - Attachment is obsolete: true
Attachment #8490896 - Flags: review?(bhearsum)
(Assignee)

Comment 28

3 years ago
http://zeller.pastebin.mozilla.org/6529119

This is the Exception that the next patch will handle.
(Reporter)

Updated

3 years ago
Attachment #8490895 - Flags: review?(bhearsum) → review+
(Reporter)

Updated

3 years ago
Attachment #8490896 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 29

3 years ago
Created attachment 8490978 [details] [diff] [review]
fix import order and pulse configuration in ship it notifier

Changed ssl=False, and the timeout has stopped being a problem :) I think this is ready to go!
Attachment #8490895 - Attachment is obsolete: true
Attachment #8490978 - Flags: review?(bhearsum)
(Reporter)

Updated

3 years ago
Attachment #8490978 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 30

3 years ago
Comment on attachment 8490978 [details] [diff] [review]
fix import order and pulse configuration in ship it notifier

Landed changes to shipit_notifier.py, but it is still no-op until puppet patch is landed.
Attachment #8490978 - Flags: checked-in+
(Reporter)

Comment 31

3 years ago
Comment on attachment 8490896 [details] [diff] [review]
puppet manifests for deploying ship it notifier

We've got a few hours before 33.0b5 goes to build, so I'm landing this so we can see it work as part of that release :).
Attachment #8490896 - Flags: checked-in+
(Reporter)

Comment 32

3 years ago
It puppetized perfectly on bm81 \o/!
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Attachment #8490896 - Attachment description: bug1055191.patch → puppet manifests for deploying ship it notifier
(Reporter)

Updated

3 years ago
Attachment #8490978 - Attachment description: tools-bug1055191.patch → fix import order and pulse configuration in ship it notifier
You need to log in before you can comment on or make changes to this bug.