Closed Bug 10552 Opened 26 years ago Closed 26 years ago

MLK: leak on every image load, [NECKO] related

Categories

(Core :: Graphics: ImageLib, defect, P3)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bruce, Assigned: warrensomebody)

Details

build from morning of July 26, 1999. IL_StreamFirstWrite() calls ImageURLImpl::GetAddress(). Under necko, this allocates memory, so we've got a couple of leaks here. Deallocation is good! cc'ing warren to have it on the necko radar. MLK: 1216 bytes leaked in 36 blocks * This memory was allocated from: malloc [rtlib.o] PL_strdup [strdup.c:30] nsCRT::strdup(const char*) [nsCRT.h:145] nsStdURL::DupString(char**,char*) [nsStdURL.cpp:594] nsStdURL::GetSpec(char**) [nsStdURL.h:141] ImageURLImpl::GetAddress() [nsImageURL.cpp:195] IL_StreamFirstWrite(il_container_struct*,const unsigned char*,int) [if.cpp:1013] NetReaderImpl::FirstWrite(const unsigned char*,int) [ilNetReader.cpp:81] ImageConsumer::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,unsigned int,unsigned int) [nsImageNetContextAsync.cpp:279] nsOnDataAvailableEvent::HandleEvent() [nsAsyncStreamListener.cpp:356] nsStreamListenerEvent::HandlePLEvent(PLEvent*) [nsAsyncStreamListener.cpp:149] PL_HandleEvent [plevent.c:509] PL_ProcessPendingEvents [plevent.c:470] nsEventQueueImpl::ProcessPendingEvents() [nsEventQueue.cpp:118] event_processor_callback(void*,int,GdkInputCondition) [nsAppShell.cpp:78] gdk_io_invoke [gdkevents.c:868] g_io_unix_dispatch [giounix.c:131] g_main_dispatch [gmain.c:647] g_main_iterate [gmain.c:854] g_main_run [gmain.c:912] gtk_main [gtkmain.c:475] nsAppShell::Run() [nsAppShell.cpp:241] nsAppShellService::Run() [nsAppShellService.cpp:468] main [nsAppRunner.cpp:720] _start [crt1.o] * Block of 51 bytes at 0xd6b3d8 * Block of 50 bytes at 0x3bd500 * Block of 45 bytes at 0xc177b0 * Block of 38 bytes (5 times); last block at 0x11597a8 * Block of 37 bytes (2 times); last block at 0xc8fb70 * Block of 36 bytes (2 times); last block at 0x8ef5b8 * Block of 35 bytes (2 times); last block at 0xc294c0 * Block of 34 bytes (4 times); last block at 0x181f6a8 * Block of 33 bytes at 0x1152710 * Block of 31 bytes at 0x1c6b980 * Block of 29 bytes (16 times); last block at 0x1d312a8
Assignee: pnunn → warren
I'll take this.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fixed (pull modules/libimg/src/if.cpp). Please verify, thanks.
Bruce, may I please defer to your verification prowess on this leak?
I'll verify this one tonight along with the others fixed today and yesterday. If for whatever reason I don't do so, feel free to assign me as QA contact tomorrow.
QA Contact: elig → bruce
[QA Assigning to Bruce, per his request. Thanks!]
You need to log in before you can comment on or make changes to this bug.