Closed Bug 105526 Opened 19 years ago Closed 19 years ago

Land Initial S/MIME on the trunk.

Categories

(Core Graveyard :: Security: UI, defect, P1)

1.0 Branch
x86
Windows 2000
defect

Tracking

(Not tracked)

VERIFIED FIXED
psm2.2

People

(Reporter: ssaux, Assigned: ssaux)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Tracking bug for
http://komodo.mozilla.org/planning/branches.cgi Initial S/MIME landing carpool.
Attached file Initial plan.
Priority: -- → P1
Target Milestone: --- → 2.2
cc ddrinan, kaie

The initial S/MIME landing will provide the Mozilla product with the first
integration of PSM and Mail/News with the NSS S/MIME toolkit (see
http://mozilla.org/projects/security/pki/nss/#smime)

It will provide very minimal UI functionality:

  - When reading signed and/or encrypted email the browser will pop up a
javascript alert telling the user about the s/mime status of the message.
  - On the compose window, the options menu will have a security item allowing
the user to encrypt and/or sign the message.
Blocks: 74157
Depends on: 106507
> - When reading signed and/or encrypted email the browser will pop up a
> javascript alert telling the user about the s/mime status of the message.

poping up an alert on seems pretty intrusive, I'm sure that's just a temporary
thing.

do signed / encryped emails have any special headers, or is the mime type
something specific, like "application/pkcs7-mime"

see mscott's messageHeaderSink in msgHdrViewOverlay.js

if you can tell the message is signed / encrypted from the headers, you can use
that to poke the header area of the message pane.

cc' mscott for comment.  cc jglick for UI issues.  


Attached patch Patch for PSM changes. (obsolete) — Splinter Review
Adding javi to cc-list.

Javi,

Please review this patch.

Thannks.
Attachment #55105 - Attachment is obsolete: true
Attached patch Updated patchSplinter Review
Javi, can you please review the updated patch?
+  <key id="esc-key"    keycode="VK_ESCAPE" oncommand="window.close();"/>

Shouldn't that be doCancel();?

+printf("Cert Nickname: %s\n", nickname.get());

That shouldn't be there.

Other than that the code looks fine to me.  sr=blizzard
blizzard: You are right with "doCancel" and the printf statement, we will change
this prior to checkin to the trunk.

I already checked this change in on OTIS_TEST_BRANCH.
Comment on attachment 55264 [details] [diff] [review]
Updated patch

sr=blizzard
Attachment #55264 - Flags: superreview+
*** Bug 106102 has been marked as a duplicate of this bug. ***
The landing of S/Mime will include the other's tab for cert manager as requested
in bug 106102.
Comment on attachment 55264 [details] [diff] [review]
Updated patch

r=javi on updated patch
Attachment #55264 - Flags: review+
Checked into the trunk. Marking FIXED.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Veerified.
Status: RESOLVED → VERIFIED
It did not work for me on the Linux 11/11 release. Even though there were
options to sign and encrypt the message in the compose window, nothing happened.
It also never popped up a box to ask me for my certificate.

I also feel strongly that the security manager should be on the tools/security
menu rather than in the totally unobvious preferences/advanced/security menu. I
was unable to find it there. Security is a dynamic thing that needs to be done
in real time, and is not a static preference.
Product: PSM → Core
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.