Land Initial S/MIME on the trunk.

VERIFIED FIXED in psm2.2

Status

Core Graveyard
Security: UI
P1
normal
VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: Stephane Saux, Assigned: Stephane Saux)

Tracking

(Blocks: 1 bug)

1.0 Branch
psm2.2
x86
Windows 2000
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

17 years ago
Tracking bug for
http://komodo.mozilla.org/planning/branches.cgi Initial S/MIME landing carpool.
(Assignee)

Comment 1

17 years ago
Created attachment 54120 [details]
Initial plan.
(Assignee)

Updated

17 years ago
Priority: -- → P1
Target Milestone: --- → 2.2
(Assignee)

Comment 2

17 years ago
cc ddrinan, kaie

(Assignee)

Comment 3

17 years ago
The initial S/MIME landing will provide the Mozilla product with the first
integration of PSM and Mail/News with the NSS S/MIME toolkit (see
http://mozilla.org/projects/security/pki/nss/#smime)

It will provide very minimal UI functionality:

  - When reading signed and/or encrypted email the browser will pop up a
javascript alert telling the user about the s/mime status of the message.
  - On the compose window, the options menu will have a security item allowing
the user to encrypt and/or sign the message.
(Assignee)

Updated

17 years ago
Depends on: 106507
> - When reading signed and/or encrypted email the browser will pop up a
> javascript alert telling the user about the s/mime status of the message.

poping up an alert on seems pretty intrusive, I'm sure that's just a temporary
thing.

do signed / encryped emails have any special headers, or is the mime type
something specific, like "application/pkcs7-mime"

see mscott's messageHeaderSink in msgHdrViewOverlay.js

if you can tell the message is signed / encrypted from the headers, you can use
that to poke the header area of the message pane.

cc' mscott for comment.  cc jglick for UI issues.  


Comment 5

17 years ago
Created attachment 55105 [details] [diff] [review]
Patch for PSM changes.

Comment 6

17 years ago
Adding javi to cc-list.

Javi,

Please review this patch.

Thannks.

Updated

17 years ago
Attachment #55105 - Attachment is obsolete: true

Comment 7

17 years ago
Created attachment 55264 [details] [diff] [review]
Updated patch

Comment 8

17 years ago
Javi, can you please review the updated patch?
+  <key id="esc-key"    keycode="VK_ESCAPE" oncommand="window.close();"/>

Shouldn't that be doCancel();?

+printf("Cert Nickname: %s\n", nickname.get());

That shouldn't be there.

Other than that the code looks fine to me.  sr=blizzard
(Assignee)

Comment 10

17 years ago
Created attachment 55341 [details]
Performance and size evaluation between experimental build and trunk builds

Comment 11

17 years ago
blizzard: You are right with "doCancel" and the printf statement, we will change
this prior to checkin to the trunk.

I already checked this change in on OTIS_TEST_BRANCH.

Comment 12

17 years ago
Comment on attachment 55264 [details] [diff] [review]
Updated patch

sr=blizzard
Attachment #55264 - Flags: superreview+

Comment 13

17 years ago
*** Bug 106102 has been marked as a duplicate of this bug. ***

Comment 14

17 years ago
The landing of S/Mime will include the other's tab for cert manager as requested
in bug 106102.

Comment 15

17 years ago
Comment on attachment 55264 [details] [diff] [review]
Updated patch

r=javi on updated patch
Attachment #55264 - Flags: review+

Comment 16

17 years ago
Checked into the trunk. Marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 17

17 years ago
Veerified.
Status: RESOLVED → VERIFIED

Comment 18

17 years ago
It did not work for me on the Linux 11/11 release. Even though there were
options to sign and encrypt the message in the compose window, nothing happened.
It also never popped up a box to ask me for my certificate.

I also feel strongly that the security manager should be on the tools/security
menu rather than in the totally unobvious preferences/advanced/security menu. I
was unable to find it there. Security is a dynamic thing that needs to be done
in real time, and is not a static preference.

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.