Tracking bug for http://komodo.mozilla.org/planning/branches.cgi Initial S/MIME landing carpool.
cc ddrinan, kaie
17 years ago
Adding javi to cc-list. Javi, Please review this patch. Thannks.
Javi, can you please review the updated patch?
+ <key id="esc-key" keycode="VK_ESCAPE" oncommand="window.close();"/> Shouldn't that be doCancel();? +printf("Cert Nickname: %s\n", nickname.get()); That shouldn't be there. Other than that the code looks fine to me. sr=blizzard
Created attachment 55341 [details] Performance and size evaluation between experimental build and trunk builds
blizzard: You are right with "doCancel" and the printf statement, we will change this prior to checkin to the trunk. I already checked this change in on OTIS_TEST_BRANCH.
Comment on attachment 55264 [details] [diff] [review] Updated patch sr=blizzard
Attachment #55264 - Flags: superreview+
*** Bug 106102 has been marked as a duplicate of this bug. ***
The landing of S/Mime will include the other's tab for cert manager as requested in bug 106102.
Comment on attachment 55264 [details] [diff] [review] Updated patch r=javi on updated patch
Attachment #55264 - Flags: review+
Checked into the trunk. Marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
It did not work for me on the Linux 11/11 release. Even though there were options to sign and encrypt the message in the compose window, nothing happened. It also never popped up a box to ask me for my certificate. I also feel strongly that the security manager should be on the tools/security menu rather than in the totally unobvious preferences/advanced/security menu. I was unable to find it there. Security is a dynamic thing that needs to be done in real time, and is not a static preference.
You need to log in before you can comment on or make changes to this bug.