1055333 - [e10s] Enable devtools/styleeditor tests

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Comment 1

[Brian Grinstead [:bgrins]]

Running tests with mochitest-devtools --e10s browser/devtools/styleeditor/

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: styleeditor-e10s-pt1.patch

Part 1 - amazingly only one test seems to be failing when running with e10s, so this moves the skip-if condition to only that test.  Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2afacad9bccc

Comment 3

[Heather Arthur [:harth]]

Comment on attachment 8474880 [details] [diff] [review]
styleeditor-e10s-pt1.patch

Looks good if try's good.

Comment 4

[Brian Grinstead [:bgrins]]

Looks like there was an unrelated failure on the try push - here's a new one: https://tbpl.mozilla.org/?tree=Try&rev=610e9cf274cf

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c6cda905d6e8

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c6cda905d6e8

Comment 7

[Brian Grinstead [:bgrins]]

I'm seeing quite a few other failures on Holly (https://tbpl.mozilla.org/?tree=Holly), like this: https://tbpl.mozilla.org/php/getParsedLog.php?id=46485165&full=1&branch=holly#error87.

Though many of them seem to be possibly caused by an error during toolbox destroy that oddly doesn't seem to be an issue with the other test suites):

10:29:35     INFO -  3977 INFO TypeError: this.webconsolePanel is undefined: Toolbox.prototype._saveSplitConsoleHeight@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:367:1
10:29:35     INFO -  3978 INFO Toolbox.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1367:5
10:29:35     INFO -  3979 INFO EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:137:11
10:29:35     INFO -  3980 INFO TabTarget.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:447:5
10:29:35     INFO -  3981 INFO TabTarget.prototype.handleEvent@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:408:9
10:29:35     INFO -  3982 INFO _beginRemoveTab@chrome://browser/content/tabbrowser.xml:2008:13
10:29:35     INFO -  3983 INFO removeTab@chrome://browser/content/tabbrowser.xml:1894:18
10:29:35     INFO -  3984 INFO removeCurrentTab@chrome://browser/content/tabbrowser.xml:1865:13
10:29:35     INFO -  3985 INFO cleanup@chrome://mochitests/content/browser/browser/devtools/styleeditor/test/head.js:60:5

Comment 8

[Brian Grinstead [:bgrins]]

Attachment: styleeditor-e10s-pt2.patch

Looks like the destroy gets called before domReady sets this.webconsolePanel.  Just checks in the destroy function before doing anything to it.  Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=f887d5c44feb

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b7147cff7a3b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7147cff7a3b

Comment 11

[Brian Grinstead [:bgrins]]

Attachment: styleeditor-e10s-pt3.patch

Found a test to skip that I missed the first time around (failures can be seen here: https://tbpl.mozilla.org/php/getParsedLog.php?id=46912519&tree=Holly&full=1).

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e4e26534c243

Comment 12

[Brian Grinstead [:bgrins]]

Had an unrelated error in the last try push, here's a new one https://tbpl.mozilla.org/?tree=Try&rev=1f4f0870b956.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/320328870802

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/320328870802

Comment 15

[Chris Peterson [:cpeterson]]

Moving DevTools test bugs to e10s milestone M7 (i.e. not blocking e10s merge to Aurora).

Comment 16

[Brian Grinstead [:bgrins]]

Attachment: styleeditor-e10s-pt4.patch

Skip remaining tests -- this won't work until Bug 1128988 is fixed (since the cmd_edit test is using a gcli command)

Comment 17

[Brian Grinstead [:bgrins]]

Attachment: styleeditor-e10s-pt4.patch

Rebased and pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=290ff488448a

Comment 18

[Brian Grinstead [:bgrins]]

Comment on attachment 8601037 [details] [diff] [review]
styleeditor-e10s-pt4.patch

The e10s dt failure here looks unrelated: https://treeherder.mozilla.org/#/jobs?repo=try&revision=290ff488448a.  Retriggered a few more just to be sure, but looking like we should be able to close this one out.

Comment 19

[Joe Walker [:jwalker]]

ni? bgrins because I'm wondering if this isn't easy to land?

Comment 20

[Brian Grinstead [:bgrins]]

New try push.. let's see what happens: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cccb2af5c5e7

Comment 21

[Brian Grinstead [:bgrins]]

Test failures on browser_styleeditor_sourcemap_watching.js in e10s on that push.  Here's a new one that might fix it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=26b5ba59b44d

Comment 22

[Brian Grinstead [:bgrins]]

Try looks good.. Checking into fx-team

Comment 23

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ebabcb64dab6

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ebabcb64dab6

Comment 25

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Actual Results: 
Unverified

Expected Results: 
Unable to perform steps due to STR are not mentioned clearly.