Closed Bug 1055348 Opened 6 years ago Closed 6 years ago

Keyboard shortcut to open WebIDE

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 34

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file, 3 obsolete files)

Need a faster way to open WebIDE itself.

Hopeful that Cmd-Opt-W (Mac) might work (appropriately converted to other platforms).
Attached patch Add WebIDE shortcut (obsolete) — Splinter Review
This works on Mac, but we'll have to verify the try builds on the other platforms too.

Paul, can you double-check Linux?

Optimizer, maybe you'd like to check on Windows?

Try: https://tbpl.mozilla.org/?tree=Try&rev=ba49d00d85b0
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8475534 - Flags: review?(paul)
Attachment #8475534 - Flags: feedback?(scrapmachines)
Comment on attachment 8475534 [details] [diff] [review]
Add WebIDE shortcut

Review of attachment 8475534 [details] [diff] [review]:
-----------------------------------------------------------------

Ctrl Shift W - Closes the current window (including all tabs)
Attachment #8475534 - Flags: review?(paul)
Attachment #8475534 - Flags: feedback?(scrapmachines)
Attachment #8475534 - Flags: feedback-
Hmm, I lost this round... I'll try to think of a new one. :)
(In reply to J. Ryan Stinnett [:jryans] from comment #3)
> I'll try to think of a new one. :)

Good luck.
Shift-F12 brings the toolbox.
What about Ctrl-Shift-F12?
Shift f12 does nothing on Windows  (if you dont have Firebug installed that is)

I think that having a similar shortcut as the toolbox makes sense as WEB IDE is not a panel in toolbox, but a completely separate IDE.
Function keys are awkward on Mac, since you have to press Fn also, so it becomes Ctrl-Shift-Fn-F12.  More the 3 keys to press gets a bit sad... ;)

Optimizer stated that Ctrl-Shift plus Y, U, O, F, L, Z, or V are free on Windows at least.

Let's try U.

It would be Mac: Cmd-Opt-U, Windows / Linux: Ctrl-Shift-U.

This time I checked all 3 myself... seems to be free everywhere.
Attached patch Add WebIDE shortcut (v2) (obsolete) — Splinter Review
Try: https://tbpl.mozilla.org/?tree=Try&rev=12f681d88434
Attachment #8475534 - Attachment is obsolete: true
Attachment #8476097 - Flags: review?(paul)
Attachment #8476097 - Flags: feedback?(scrapmachines)
Comment on attachment 8476097 [details] [diff] [review]
Add WebIDE shortcut (v2)

ctrl-shift-u is used to start unicode sequences.
Attachment #8476097 - Flags: review?(paul) → review-
(relieved because that shortcut is used by one of my addon and I did not want to get it overridden by Firefox internal shortcut :P)
Attachment #8476097 - Flags: feedback?(scrapmachines)
This is as much fun as I expected it to be! :P

The other letters seem too similar to important commands like paste, find, etc.

For round 3, let's try: Shift-F11!

Try: https://tbpl.mozilla.org/?tree=Try&rev=1b9d7f78bb9e
Attachment #8476097 - Attachment is obsolete: true
Attachment #8476779 - Flags: review?(paul)
Attachment #8476779 - Flags: feedback?(scrapmachines)
Shift F11 is used by Firebug for step into / over

Although, that only gets into effect when firebug is open and focused. Not sure if we should treat it as a conflict or not.

Other than that, Shift F11 is fine.
Okay, well, best to avoid conflicts, even if it's only when debugger is open.

Round 4: Shift-F8!

Try: https://tbpl.mozilla.org/?tree=Try&rev=24a6e183f280
Attachment #8476779 - Attachment is obsolete: true
Attachment #8476779 - Flags: review?(paul)
Attachment #8476779 - Flags: feedback?(scrapmachines)
Attachment #8476833 - Flags: review?(paul)
Attachment #8476833 - Flags: feedback?(scrapmachines)
Comment on attachment 8476833 [details] [diff] [review]
Add WebIDE shortcut (v4)

Review of attachment 8476833 [details] [diff] [review]:
-----------------------------------------------------------------

Free on windows too
Attachment #8476833 - Flags: feedback?(scrapmachines) → feedback+
Attachment #8476833 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/5c96ff682443
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Shift+F8 opens WebIDE in all platforms using Aurora 34.0a2 2014-10-08.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
QA Contact: petruta.rasa
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.