If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[SMS] Threads view Unread indicator and contact photo are not screen reader friendly

RESOLVED FIXED

Status

Firefox OS
Gaia::SMS
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [b2ga11y p=1])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I don't think they use the <aside> tag appropriately. In any case, they need to be labeled in a way that the screen reader could use.
(Assignee)

Updated

3 years ago
Component: Gaia → Gaia::SMS
(Assignee)

Updated

3 years ago
Whiteboard: [b2ga11y p=1]
(Assignee)

Comment 1

3 years ago
Created attachment 8474918 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014
Attachment #8474918 - Flags: review?(azasypkin)
Comment on attachment 8474918 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014

Hey Eitan,

I've left a few comments on GitHub, especially one related to thread in "draft" state that is currently broken.

Please, set r? flag again whenever you're ready and thanks for the patch!
Attachment #8474918 - Flags: review?(azasypkin)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8474918 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014

Thanks, Oleg for the feedback.

New patch is up!
Attachment #8474918 - Flags: review?(azasypkin)
Comment on attachment 8474918 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014

Hey Eitan, now it's good except that it still hides draft icon :)
Attachment #8474918 - Flags: review?(azasypkin)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8474918 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014

Oops! Fixed.
Attachment #8474918 - Flags: review?(azasypkin)
Comment on attachment 8474918 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23014

Looks fine now, r=me!

Thanks!
Attachment #8474918 - Flags: review?(azasypkin) → review+
(Assignee)

Comment 7

3 years ago
https://github.com/mozilla-b2g/gaia/commit/aa72df680c56bad1507ca0ee2d640d300fe91a1d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.